You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Vinayak Marraiya <vi...@freestoneinfotech.com> on 2024/06/10 12:29:02 UTC
Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
-----------------------------------------------------------
(Updated June 10, 2024, 12:29 p.m.)
Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal Shah.
Repository: atlas
Description (updated)
-------
Relationship search is enabled (for backend and UI), by default and the value for atlas.relationship.search.enabled is false.
Relationship search will be disabled from backend and UI, if the value for atlas.relationship.search.enabled is true.
Diffs
-----
dashboardv2/public/css/scss/override.scss 0c5f8bc0d
dashboardv2/public/js/main.js f0cea7999
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420
dashboardv2/public/js/utils/Globals.js 431a24b38
dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e
dashboardv3/public/js/main.js 7423c88c3
dashboardv3/public/js/utils/Globals.js 410d82881
dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8
dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js ea7185b35
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java c3a9106fa
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 27ec59d37
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f
Diff: https://reviews.apache.org/r/74851/diff/10/
Testing
-------
Tested following:
1. Checked whether default behaviour (relationship search APIs are disabled in UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work even when relationship search is disabled.
4. Tested disabling and enabling of property
Precommit - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console
Thanks,
Vinayak Marraiya
Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable
Posted by Vinayak Marraiya <vi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
-----------------------------------------------------------
(Updated June 10, 2024, 12:36 p.m.)
Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal Shah.
Repository: atlas
Description (updated)
-------
Relationship search is now disabled (for backend and UI),by default and the value for atlas.relationship.search.enabled is false.
Relationship search will be enabled from backend and UI, if the value for atlas.relationship.search.enabled is true.
Diffs
-----
dashboardv2/public/css/scss/override.scss 0c5f8bc0d
dashboardv2/public/js/main.js f0cea7999
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420
dashboardv2/public/js/utils/Globals.js 431a24b38
dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e
dashboardv3/public/js/main.js 7423c88c3
dashboardv3/public/js/utils/Globals.js 410d82881
dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8
dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js ea7185b35
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java c3a9106fa
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 27ec59d37
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f
Diff: https://reviews.apache.org/r/74851/diff/10/
Testing
-------
Tested following:
1. Checked whether default behaviour (relationship search APIs are disabled in UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work even when relationship search is disabled.
4. Tested disabling and enabling of property
Precommit - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console
Thanks,
Vinayak Marraiya
Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable
Posted by Vinayak Marraiya <vi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
-----------------------------------------------------------
(Updated June 10, 2024, 12:34 p.m.)
Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal Shah.
Repository: atlas
Description (updated)
-------
Relationship search is disabled (for backend and UI),by default and the value for atlas.relationship.search.enabled is false.
Relationship search will be enabled from backend and UI, if the value for atlas.relationship.search.enabled is true.
Diffs
-----
dashboardv2/public/css/scss/override.scss 0c5f8bc0d
dashboardv2/public/js/main.js f0cea7999
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420
dashboardv2/public/js/utils/Globals.js 431a24b38
dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e
dashboardv3/public/js/main.js 7423c88c3
dashboardv3/public/js/utils/Globals.js 410d82881
dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8
dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js ea7185b35
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java c3a9106fa
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 27ec59d37
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f
Diff: https://reviews.apache.org/r/74851/diff/10/
Testing
-------
Tested following:
1. Checked whether default behaviour (relationship search APIs are disabled in UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work even when relationship search is disabled.
4. Tested disabling and enabling of property
Precommit - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console
Thanks,
Vinayak Marraiya
Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable
Posted by Vinayak Marraiya <vi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
-----------------------------------------------------------
(Updated June 10, 2024, 12:33 p.m.)
Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal Shah.
Repository: atlas
Description (updated)
-------
Relationship search is enabled (for backend and UI),by default and the value for atlas.relationship.search.enabled is true.
Relationship search will be disabled from backend and UI, if the value for atlas.relationship.search.enabled is false.
Diffs
-----
dashboardv2/public/css/scss/override.scss 0c5f8bc0d
dashboardv2/public/js/main.js f0cea7999
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420
dashboardv2/public/js/utils/Globals.js 431a24b38
dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e
dashboardv3/public/js/main.js 7423c88c3
dashboardv3/public/js/utils/Globals.js 410d82881
dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8
dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js ea7185b35
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java c3a9106fa
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 27ec59d37
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f
Diff: https://reviews.apache.org/r/74851/diff/10/
Testing
-------
Tested following:
1. Checked whether default behaviour (relationship search APIs are disabled in UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work even when relationship search is disabled.
4. Tested disabling and enabling of property
Precommit - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console
Thanks,
Vinayak Marraiya
Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable
Posted by Vinayak Marraiya <vi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
-----------------------------------------------------------
(Updated June 10, 2024, 12:30 p.m.)
Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal Shah.
Repository: atlas
Description (updated)
-------
Relationship search is enabled (for backend and UI),by default and the value for atlas.relationship.search.enabled is false.
Relationship search will be disabled from backend and UI, if the value for atlas.relationship.search.enabled is true.
Diffs
-----
dashboardv2/public/css/scss/override.scss 0c5f8bc0d
dashboardv2/public/js/main.js f0cea7999
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420
dashboardv2/public/js/utils/Globals.js 431a24b38
dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e
dashboardv3/public/js/main.js 7423c88c3
dashboardv3/public/js/utils/Globals.js 410d82881
dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8
dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js ea7185b35
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java c3a9106fa
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 27ec59d37
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f
Diff: https://reviews.apache.org/r/74851/diff/10/
Testing
-------
Tested following:
1. Checked whether default behaviour (relationship search APIs are disabled in UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work even when relationship search is disabled.
4. Tested disabling and enabling of property
Precommit - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console
Thanks,
Vinayak Marraiya