You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Lukasdoe (via GitHub)" <gi...@apache.org> on 2025/05/22 08:37:05 UTC
[PR] GH-46551: [C++] Use `std::string_view` for type schema API [arrow]
Lukasdoe opened a new pull request, #46553:
URL: https://github.com/apache/arrow/pull/46553
This is my attempt on implementing #46551.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46551: [C++] Use `std::string_view` for type schema API [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46553:
URL: https://github.com/apache/arrow/pull/46553#issuecomment-2903828676
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4312780907fb2a1485933232c5ca1295036f7e11.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/42772126039) has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46551: [C++] Use `std::string_view` for type schema API [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46553:
URL: https://github.com/apache/arrow/pull/46553#issuecomment-2900739683
Could you use our PR template instead of removing it entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46551: [C++] Use `std::string_view` for type schema API [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46553:
URL: https://github.com/apache/arrow/pull/46553#issuecomment-2900379014
:warning: GitHub issue #46551 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46551: [C++] Use `std::string_view` for type schema API [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46553:
URL: https://github.com/apache/arrow/pull/46553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46551: [C++] Use `std::string_view` for type schema API [arrow]
Posted by "Lukasdoe (via GitHub)" <gi...@apache.org>.
Lukasdoe commented on PR #46553:
URL: https://github.com/apache/arrow/pull/46553#issuecomment-2902658587
just changed the description above to adhere to the template. Let me know if there's anything else missing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org