You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "davisp (via GitHub)" <gi...@apache.org> on 2024/09/27 15:48:31 UTC
[I] Keep the original SQL for CreateExternalTable::definition [datafusion]
davisp opened a new issue, #12652:
URL: https://github.com/apache/datafusion/issues/12652
### Is your feature request related to a problem or challenge?
Currently, the CreateExternalTable definition is just a stringified version of the statement, rather than the original SQL that was parsed.
### Describe the solution you'd like
I'd like to propose capturing the original SQL as provided and storing that instead so that when a definition is displayed, it matches what a user originally provided.
### Describe alternatives you've considered
Nothing comes to mind. Its a fairly small change.
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Keep the original SQL for CreateExternalTable::definition [datafusion]
Posted by "davisp (via GitHub)" <gi...@apache.org>.
davisp commented on issue #12652:
URL: https://github.com/apache/datafusion/issues/12652#issuecomment-2379630239
I've opened a draft PR to show that there's a what appears to be a reasonable approach to handling this if anyone is interested in checking that out. I'm fully aware that its a bit hacky and a proper PR will likely involve splitting some of the logic into the sqlparser crate which I'm more than happy to do as a precondition. I just didn't want to invest that much time in pursuing this until there's some general agreement that this is even a desirable change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Keep the original SQL for CreateExternalTable::definition [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on issue #12652:
URL: https://github.com/apache/datafusion/issues/12652#issuecomment-2511200101
The logical plan should describe the logical structure of the query/statement, it should not carry the syntax.
We should rather work towards removing `CreateExternalTable::definition` field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org