[jira] [Commented] (KAFKA-15327) Client consumer should commit offsets on close

["Lucas Brutschy (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789147#comment-17789147 ] 

Lucas Brutschy commented on KAFKA-15327:
----------------------------------------

[~pnee] can this issue be closed? have you checked the acceptance criteria (integration tests pass?)

> Client consumer should commit offsets on close
> ----------------------------------------------
>
>                 Key: KAFKA-15327
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15327
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients, consumer
>            Reporter: Lianet Magrans
>            Assignee: Philip Nee
>            Priority: Major
>              Labels: kip-848, kip-848-client-support, kip-848-preview
>
> In the current implementation of the KafkaConsumer, the ConsumerCoordinator commits offsets before the consumer is closed, with a call to 
> maybeAutoCommitOffsetsSync(timer);
> The async consumer should provide the same behaviour to commit offsets on close. 
> This fix should allow to successfully run the following integration tests (defined in PlaintextConsumerTest)
>  * testAutoCommitOnClose
>  * testAutoCommitOnCloseAfterWakeup



--
This message was sent by Atlassian Jira
(v8.20.10#820010)