You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/06/22 00:43:12 UTC

[GitHub] [james-project] chibenwa opened a new pull request #505: [PERFORMANCE] A collection of minor performance enhancements

chibenwa opened a new pull request #505:
URL: https://github.com/apache/james-project/pull/505


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #505:
URL: https://github.com/apache/james-project/pull/505#issuecomment-865444392


   https://github.com/apache/james-project/pull/505/commits/5c7ab34fe3eda088e4a99930b2c79aa754d60084
   
   ## Before
   
   ![Screenshot from 2021-06-22 08-01-45](https://user-images.githubusercontent.com/6928740/122846515-3110af00-d330-11eb-9dd5-74c412411ee6.png)
   
   0.12% of CPU, 0.09% of memory
   
   ## After
   
   No traces :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #505:
URL: https://github.com/apache/james-project/pull/505#issuecomment-865440094


   https://github.com/apache/james-project/pull/505/commits/2356b2164c938ef0600f804d26d37c62de6015da
   
   ## Before
   
   `Message$Builder.build` takes 11.4% of MIME4J parsing time, 10% of MIME4J memory allocation (for the header parsing use case):
   
   ![Screenshot from 2021-06-22 07-45-42](https://user-images.githubusercontent.com/6928740/122845461-045b9800-d32e-11eb-8671-0966faac6ce9.png)
   
   ## After
   
   ![Screenshot from 2021-06-22 07-48-27](https://user-images.githubusercontent.com/6928740/122845637-57cde600-d32e-11eb-87d4-c41ebfe90bb4.png)
   
   Disappeared!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa merged pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #505:
URL: https://github.com/apache/james-project/pull/505


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] rouazana commented on a change in pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #505:
URL: https://github.com/apache/james-project/pull/505#discussion_r655989076



##########
File path: server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/model/message/view/MessageViewFactory.java
##########
@@ -80,6 +80,9 @@ static void assertOneMessageId(Collection<MessageResult> messageResults) {
         }
 
         private static boolean hasOnlyOneMessageId(Collection<MessageResult> messageResults) {
+            if (messageResults.size() <= 1) {

Review comment:
       you mean `if (messageResults.size() == 1)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #505:
URL: https://github.com/apache/james-project/pull/505#issuecomment-865443260


   https://github.com/apache/james-project/pull/505/commits/0cd70cfde85f12f8cd9b7bbef54cc7215b9337ba
   
   ## Before
   
   0.2% of CPU, 0.34% of memory allocation.
   
   ![Screenshot from 2021-06-22 07-58-20](https://user-images.githubusercontent.com/6928740/122846322-c9f2fa80-d32f-11eb-8bf7-3b3982d7ccbf.png)
   
   ## After
   
   No traces :-) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #505:
URL: https://github.com/apache/james-project/pull/505#issuecomment-865440094






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #505:
URL: https://github.com/apache/james-project/pull/505#issuecomment-865440890


   https://github.com/apache/james-project/pull/505/commits/61c63418dfcff2f6003dda0b7ac26d096c2bd684
   
   ## Before
   
   ![Screenshot from 2021-06-22 07-50-14](https://user-images.githubusercontent.com/6928740/122845750-906dbf80-d32e-11eb-8e71-f4088314df10.png)
   
   We can clearly see getUserFlags is called twice.
   
   ## After
   
   Not anmore.
   
   ![Screenshot from 2021-06-22 07-51-48](https://user-images.githubusercontent.com/6928740/122845840-c14df480-d32e-11eb-89e4-a3dea43b1ed2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #505:
URL: https://github.com/apache/james-project/pull/505#issuecomment-865442378


   https://github.com/apache/james-project/pull/505/commits/9d113fb78f543e8f7beb312a8f5462093407ad80
   
   ## Before
   
   ![Screenshot from 2021-06-22 07-53-53](https://user-images.githubusercontent.com/6928740/122845994-17bb3300-d32f-11eb-9626-7da725dcf426.png)
   
   Takes 0.2 % of CPU and 0.5% of memory allocation.
   
   ## After
   
   ![Screenshot from 2021-06-22 07-56-01](https://user-images.githubusercontent.com/6928740/122846128-6537a000-d32f-11eb-9553-cbfadf8fbf74.png)
   
   Slimmer it now takes just 0.14% of CPU and only 0.25% of memory... Not game changer but nice to take.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #505: [PERFORMANCE] A collection of minor performance enhancements

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #505:
URL: https://github.com/apache/james-project/pull/505#issuecomment-866840298


   Just squashed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org