[GitHub] [arrow-cookbook] raulcd commented on a diff in pull request #292: ci: update java testing to support run with python 3.9 version

["raulcd (via GitHub)" <gi...@apache.org>]

raulcd commented on code in PR #292:
URL: https://github.com/apache/arrow-cookbook/pull/292#discussion_r1144886616


##########
java/ext/javadoctest.py:
##########
@@ -18,7 +18,7 @@
 import pathlib
 import subprocess
 

Review Comment:
   ```suggestion
   from typing import Any, Dict
   
   ```



##########
java/ext/javadoctest.py:
##########
@@ -99,7 +99,7 @@ def clean_output(self, output: str):
         output = (4*' ').join(output.split('\t'))
         return output
 
-def setup(app) -> Dict[str, Any]:
+def setup(app) -> dict[str, Any]:

Review Comment:
   ```suggestion
   def setup(app) -> Dict[str, Any]:
   ```



##########
java/ext/javadoctest.py:
##########
@@ -18,7 +18,7 @@
 import pathlib
 import subprocess
 
-from sphinx.ext.doctest import (Any, Dict, DocTestBuilder, TestcodeDirective,
+from sphinx.ext.doctest import (Any, DocTestBuilder, TestcodeDirective,

Review Comment:
   ```suggestion
   from sphinx.ext.doctest import (DocTestBuilder, TestcodeDirective,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org