You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2015/04/22 14:52:51 UTC
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/617
[runtime] Bump Netty version to 4.27.Final and add javassist
@rmetzger, javassist is set in the root POM. Is it OK to leave it in flink-runtime as I have it now w/o version?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/incubator-flink javassist
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #617
----
commit 6a91d722005d7f8d138e8553f92a134c52209de8
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-04-22T12:50:38Z
[runtime] Bump Netty version to 4.27.Final and add javassist
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
Posted by uce <gi...@git.apache.org>.
Github user uce closed the pull request at:
https://github.com/apache/flink/pull/617
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/617#issuecomment-95218150
OK, then this is good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/617#issuecomment-95173776
No, I would not add a dependency there. Maybe a comment that we've managed a transitive dependency of hbase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/617
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
Posted by uce <gi...@git.apache.org>.
GitHub user uce reopened a pull request:
https://github.com/apache/flink/pull/617
[runtime] Bump Netty version to 4.27.Final and add javassist
@rmetzger, javassist is set in the root POM. Is it OK to leave it in flink-runtime as I have it now w/o version?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/incubator-flink javassist
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #617
----
commit 6a91d722005d7f8d138e8553f92a134c52209de8
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-04-22T12:50:38Z
[runtime] Bump Netty version to 4.27.Final and add javassist
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/617#issuecomment-95169398
Yap. I've just seen that there is no reference to javassist in the flink-hbase pom. Is that intentional? Shouldn't we also add a dependency there w/o the version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/617#issuecomment-95163295
Ah .. we didn't change the javaassist version ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [runtime] Bump Netty version to 4.27.Final and...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/617#issuecomment-95162838
Are we sure that HBase is still working?
I think there are no automated tests for Hbase ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---