You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Goldstein Lyor (JIRA)" <ji...@apache.org> on 2018/10/23 11:39:00 UTC
[jira] [Comment Edited] (SSHD-849) Possible race condition for
local port forwarding channels
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660470#comment-16660470 ]
Goldstein Lyor edited comment on SSHD-849 at 10/23/18 11:38 AM:
----------------------------------------------------------------
I take it back - after reviewing the code (see my remarks) there are still problems - mainly the fact the `completedFuture` may remain in undefined state if exceptions occur. I like your idea though and am working on an update of my initial code based on yours.
was (Author: lgoldstein):
I take it back - after reviewing the code (see my remarks) there are still problems - mainly the fact the `completedFuture` may remain in undefined state if exceptions occur.
> Possible race condition for local port forwarding channels
> ----------------------------------------------------------
>
> Key: SSHD-849
> URL: https://issues.apache.org/jira/browse/SSHD-849
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.1.1
> Reporter: Roberto Deandrea
> Priority: Major
>
> Hi Lyor,
> We found another critical race condition sending data through local port forwarding channels that causes loosing data bytes sent by client to target server.
> As soon as possible I will open a pull request with our potential changes to fix this issue.
> I let you know when done because I would like to know your feedback.
> Hi Lyor,
> We made some code changes to your proposed solution based on ClientChannelPendingMessageQueue.
> You can find our commit at https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d
> Can you review our code and give us feedback ?
> If it satisfies you can you merge it in Apache SSHD master repository ?
> Cheers.
> Roberto
> Cheers
> Roberto
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)