You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/05 00:17:26 UTC

[GitHub] [beam] damccorm opened a new issue, #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries flaky

damccorm opened a new issue, #21533:
URL: https://github.com/apache/beam/issues/21533

   Example failures: 
   * https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/21726/testReport/junit/org.apache.beam.sdk.io.gcp.spanner.changestreams/SpannerChangeStreamErrorTest/testUnavailableExceptionRetries/
   * https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/21723/testReport/junit/org.apache.beam.sdk.io.gcp.spanner.changestreams/SpannerChangeStreamErrorTest/testUnavailableExceptionRetries/
   
   ```
   
   java.lang.AssertionError: 
   Expected: a value greater than <1>
        but: <0> was less than <1>
   	at
   org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
   	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
   	at
   org.apache.beam.sdk.io.gcp.spanner.changestreams.SpannerChangeStreamErrorTest.testUnavailableExceptionRetries(SpannerChangeStreamErrorTest.java:166)
   	at
   sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at
   sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at
   org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
   	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
   	at
   org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
   	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
   	at
   org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
   	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
   	at
   org.apache.beam.sdk.testing.TestPipeline$1.evaluate(TestPipeline.java:323)
   	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
   	at
   org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
   	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
   
   ```
   
   
   Imported from Jira [BEAM-14152](https://issues.apache.org/jira/browse/BEAM-14152). Original Jira may contain additional context.
   Reported by: lcwik.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] thiagotnunes commented on issue #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries hard failure (disabled)

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on issue #21533:
URL: https://github.com/apache/beam/issues/21533#issuecomment-1284700325

   @nancyxu123 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries flaky

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #21533:
URL: https://github.com/apache/beam/issues/21533#issuecomment-1284476262

   @zoercai @thiagotnunes this test is now a hard failure. It looks like it is caused by the way it uses mocking, even though the results of a retry may be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries flaky

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #21533:
URL: https://github.com/apache/beam/issues/21533#issuecomment-1283161772

   Confirmed this on my first try: https://scans.gradle.com/s/s3rz2sggpks4m/tests/:sdks:java:io:google-cloud-platform:test/org.apache.beam.sdk.io.gcp.spanner.changestreams.SpannerChangeStreamErrorTest/testUnavailableExceptionRetries?top-execution=1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on issue #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries hard failure (disabled)

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on issue #21533:
URL: https://github.com/apache/beam/issues/21533#issuecomment-1406929345

   Looks like the mockSpannerService in SpannerChangeStreamErrorTest actually does not taking effect. It also affects current test suite beam_PreCommit_Java_GCP_IO_Direct where `org.apache.beam.sdk.io.gcp.spanner.changestreams.SpannerChangeStreamErrorTest.testAbortedExceptionNotRetriedithDefaultsForStreamSqlRetrySettings` costs 5 minutes exactly on success run. The test being success due to real grpc DEADLINE_EXCEEDED.
   
   Reopen the issue for now for mockSpannerService not working properly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries flaky

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #21533:
URL: https://github.com/apache/beam/issues/21533#issuecomment-1284409215

   Seems the test is expecting a particular proto class in a mock, so it isn't lining up with expected results


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries flaky

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #21533:
URL: https://github.com/apache/beam/issues/21533#issuecomment-1284396122

   So far 100% failure rate, not flaking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles closed issue #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries hard failure (disabled)

Posted by GitBox <gi...@apache.org>.
kennknowles closed issue #21533: SpannerChangeStreamErrorTest.testUnavailableExceptionRetries hard failure (disabled)
URL: https://github.com/apache/beam/issues/21533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org