[jira] [Updated] (PIG-3155) TestTypeCheckingValidatorNewLP.testSortWithInnerPlan3 fails in trunk

["Cheolsoo Park (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cheolsoo Park updated PIG-3155:
-------------------------------

    Attachment: PIG-3155.patch

The test case expects an exception to be thrown from an expression of "bytearray % chararray", but it isn't.

The following fixes the test case:
{code}
--- a/src/org/apache/pig/newplan/logical/visitor/TypeCheckingExpVisitor.java
+++ b/src/org/apache/pig/newplan/logical/visitor/TypeCheckingExpVisitor.java
@@ -209,6 +209,8 @@ public class TypeCheckingExpVisitor extends LogicalExpressionVisitor{
         } else if (lhsType == DataType.BYTEARRAY) {
             if (rhsType == DataType.INTEGER || rhsType == DataType.LONG || rhsType == DataType.BIGINTEGER) {
                 insertCast(binOp, rhsType, binOp.getLhs());
+            } else {
+                error = true;
             }
{code}
                
> TestTypeCheckingValidatorNewLP.testSortWithInnerPlan3 fails in trunk
> --------------------------------------------------------------------
>
>                 Key: PIG-3155
>                 URL: https://issues.apache.org/jira/browse/PIG-3155
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.12
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>             Fix For: 0.12
>
>         Attachments: PIG-3155.patch
>
>
> To reproduce the failure, do:
> {code}
> ant clean test -Dtestcase=TestTypeCheckingValidatorNewLP
> {code}
> The test fails with the following error:
> {code}
> Error expected
> junit.framework.AssertionFailedError: Error expected
>     at org.apache.pig.test.TestTypeCheckingValidatorNewLP.testSortWithInnerPlan3(TestTypeCheckingValidatorNewLP.java:1570)
> {code}
> I found that this was introduced by PIG-2764.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira