You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/17 09:31:12 UTC
[jira] [Commented] (CB-11262) Add a warning about prerelease
lib/cli usage
[ https://issues.apache.org/jira/browse/CB-11262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286286#comment-15286286 ]
ASF GitHub Bot commented on CB-11262:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/251#discussion_r63491154
--- Diff: src/cli.js ---
@@ -234,17 +234,24 @@ function cli(inputArgs) {
var args = nopt(knownOpts, shortHands, inputArgs);
- if (args.version) {
- var cliVersion = require('../package').version;
+ var cliVersion = require('../package').version;
+ // TODO: Use semver.prerelease when it gets released
+ var usingPrerelease = /-nightly|-dev$/.exec(cliVersion);
+ if (args.version || usingPrerelease) {
var libVersion = require('cordova-lib/package').version;
var toPrint = cliVersion;
if (cliVersion != libVersion || /-dev$/.exec(libVersion)) {
toPrint += ' (cordova-lib@' + libVersion + ')';
}
- console.log(toPrint);
- return Q();
- }
+ if (args.version) {
+ console.log(toPrint);
+ return Q();
+ } else {
+ // Show a warning and continue
+ console.log('Warning: using prerelease version ' + toPrint);
--- End diff --
Can we use logger to print this? This would make it more visible, if we get this printed to console with 'warn' log level.
> Add a warning about prerelease lib/cli usage
> --------------------------------------------
>
> Key: CB-11262
> URL: https://issues.apache.org/jira/browse/CB-11262
> Project: Apache Cordova
> Issue Type: Task
> Components: CLI
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org