You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2020/10/16 17:07:08 UTC
[GitHub] [lucenenet] joneskj55 opened a new pull request #369: Add fork me on GitHub
joneskj55 opened a new pull request #369:
URL: https://github.com/apache/lucenenet/pull/369
This PR adds the Fork me on GitHub ribbon to the site. I was unable to to build and test the solution on a local port (I tried several routes) however, I was able to test in the browser. I know that is not the ideal way but I could not get a local port running. Please let me know if this does not suffice and I will continue to try and get a successful build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #369: Add fork me on GitHub
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #369:
URL: https://github.com/apache/lucenenet/pull/369#issuecomment-711039054
Thanks. The color scheme looks great.
## Build
When running the website build script, it is no longer processing all of the tags correctly so the home page looks like this:
DocFx doesn't process markdown files that contain plain HTML (`index.md`, `issue-tracker.md`, etc). I confirmed this by removing the `span` from `index.md`. However, that only fixes the home page. When the `span` is removed from other pages, the ribbon is no longer visible.
I don't have a lot of experience with DocFx, but I believe that instead of putting the `span` tag in Markdown, you need to put it inside a partial file (for example, `\websites\site\lucenenet\partials\head.tmpl.partial` and `\websites\site\lucenenet\partials\head.tmpl.partial`). I believe in this case you may need to generate an additional `.partial` file to put the HTML into the body of every page, rather than in the header. There is a [quick guide to customizing a docfx site](https://www.cazzulino.com/customize-docfx.html), or if you need more detailed info, I suggest looking at the [DocFx Manual](https://dotnet.github.io/docfx/tutorial/docfx.exe_user_manual.html).
@Shazwazza - Can you provide some additional insights?
## Layout
On the 2 largest resolution viewports, the ribbon overlaps the rightmost menu item when resizing the browser. Could we perhaps add some padding to the right side to keep all of the menu items from being hidden?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] joneskj55 commented on pull request #369: Add fork me on GitHub
Posted by GitBox <gi...@apache.org>.
joneskj55 commented on pull request #369:
URL: https://github.com/apache/lucenenet/pull/369#issuecomment-711057235
Ok thanks! I am able to build now so I can actually see my changes. I'll get this fixed and add another commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #369: Add fork me on GitHub
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #369:
URL: https://github.com/apache/lucenenet/pull/369#issuecomment-715072695
Closing, as this was superseded by #374.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 closed pull request #369: Add fork me on GitHub
Posted by GitBox <gi...@apache.org>.
NightOwl888 closed pull request #369:
URL: https://github.com/apache/lucenenet/pull/369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org