You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by "Michal Galet (JIRA)" <ji...@apache.org> on 2012/10/30 14:04:17 UTC

[dev] [jira] [Created] (LIBCLOUD-251) Expose query and control settings functionality for vCloud driver

Michal Galet created LIBCLOUD-251:
-------------------------------------

             Summary: Expose query and control settings functionality for vCloud driver
                 Key: LIBCLOUD-251
                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-251
             Project: Libcloud
          Issue Type: New Feature
          Components: Compute
    Affects Versions: 0.11.2
            Reporter: Michal Galet


* Provide functionality to get and set control access for vApps. This way created vApps can be shared between users/groups or everyone.
* Expose generic query method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[dev] [jira] [Commented] (LIBCLOUD-251) Expose query and control settings functionality for vCloud driver

Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LIBCLOUD-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488097#comment-13488097 ] 

Tomaz Muraus commented on LIBCLOUD-251:
---------------------------------------

Thanks for the patch. I've merged it into trunk with the following changes:

- Use urlencode from libcloud.utils.py3
- Use self.assert* methods instead of assert (changed MockHttp class to inherit from unittest.TestCase)
- if self.network -> if self.network is not None
- body -> str(body) inside the test, inside Python 3.2 body type is bytes, not str
- other style things - line length, " -> ', etc.
- Use new style classes (inherit from object)

There are still a bunch of issues which can be solved in a nicer way. For examples:

+        # This is a workaround for filter parameter encoding
+        # the urllib encodes (name==Developers%20Only) into
+        # %28name%3D%3DDevelopers%20Only%29) which is not accepted by vCloud

But I decided to merge an initial version and you can incrementally fix other things. You can see all the changes I made at http://svn.apache.org/viewvc?view=revision&revision=1404292

Next time please make sure issues like this are addresses when attaching a patch. Thanks!
                
> Expose query and control settings functionality for vCloud driver
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-251
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-251
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Compute
>    Affects Versions: 0.11.2
>            Reporter: Michal Galet
>              Labels: vcloud
>         Attachments: LIBCLOUD-251.patch
>
>
> * Provide functionality to get and set control access for vApps. This way created vApps can be shared between users/groups or everyone.
> * Expose generic query method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[dev] [jira] [Resolved] (LIBCLOUD-251) Expose query and control settings functionality for vCloud driver

Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LIBCLOUD-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomaz Muraus resolved LIBCLOUD-251.
-----------------------------------

    Resolution: Fixed
      Assignee: Tomaz Muraus
    
> Expose query and control settings functionality for vCloud driver
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-251
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-251
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Compute
>    Affects Versions: 0.11.2
>            Reporter: Michal Galet
>            Assignee: Tomaz Muraus
>              Labels: vcloud
>         Attachments: LIBCLOUD-251.patch
>
>
> * Provide functionality to get and set control access for vApps. This way created vApps can be shared between users/groups or everyone.
> * Expose generic query method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[dev] [jira] [Commented] (LIBCLOUD-251) Expose query and control settings functionality for vCloud driver

Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LIBCLOUD-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487507#comment-13487507 ] 

Tomaz Muraus commented on LIBCLOUD-251:
---------------------------------------

Just FYI, the way you are using urlencode won't work with all the supported Python version. You need to use urlencode from libcloud.utils.p3.

You can grep code for "urlencode" for other examples.
                
> Expose query and control settings functionality for vCloud driver
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-251
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-251
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Compute
>    Affects Versions: 0.11.2
>            Reporter: Michal Galet
>              Labels: vcloud
>         Attachments: LIBCLOUD-251.patch
>
>
> * Provide functionality to get and set control access for vApps. This way created vApps can be shared between users/groups or everyone.
> * Expose generic query method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[dev] [jira] [Commented] (LIBCLOUD-251) Expose query and control settings functionality for vCloud driver

Posted by "Michal Galet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LIBCLOUD-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487826#comment-13487826 ] 

Michal Galet commented on LIBCLOUD-251:
---------------------------------------

Sorry about that. I didn't know. Thanks!
                
> Expose query and control settings functionality for vCloud driver
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-251
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-251
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Compute
>    Affects Versions: 0.11.2
>            Reporter: Michal Galet
>              Labels: vcloud
>         Attachments: LIBCLOUD-251.patch
>
>
> * Provide functionality to get and set control access for vApps. This way created vApps can be shared between users/groups or everyone.
> * Expose generic query method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[dev] [jira] [Updated] (LIBCLOUD-251) Expose query and control settings functionality for vCloud driver

Posted by "Michal Galet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LIBCLOUD-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michal Galet updated LIBCLOUD-251:
----------------------------------

    Attachment: LIBCLOUD-251.patch

Patch against the current version of trunk (d6ba49113c6197bbd7a531658cf4c3b400b28bc8)
                
> Expose query and control settings functionality for vCloud driver
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-251
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-251
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Compute
>    Affects Versions: 0.11.2
>            Reporter: Michal Galet
>              Labels: vcloud
>         Attachments: LIBCLOUD-251.patch
>
>
> * Provide functionality to get and set control access for vApps. This way created vApps can be shared between users/groups or everyone.
> * Expose generic query method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[dev] [jira] [Commented] (LIBCLOUD-251) Expose query and control settings functionality for vCloud driver

Posted by "Michal Galet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LIBCLOUD-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486848#comment-13486848 ] 

Michal Galet commented on LIBCLOUD-251:
---------------------------------------

A patch will be provided soon
                
> Expose query and control settings functionality for vCloud driver
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-251
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-251
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Compute
>    Affects Versions: 0.11.2
>            Reporter: Michal Galet
>              Labels: vcloud
>
> * Provide functionality to get and set control access for vApps. This way created vApps can be shared between users/groups or everyone.
> * Expose generic query method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira