[GitHub] [systemds] Baunsgaard commented on pull request #1106: [MINOR] Federated Type Fixes

[GitBox <gi...@apache.org>]

Baunsgaard commented on pull request #1106:
URL: https://github.com/apache/systemds/pull/1106#issuecomment-727640449


   > A general question on this: isn't a full block just a row or column partitioned federated matrix and hence the existing operations can directly be applied. Yes, we could implement them more efficiently (basic forwarding, no aggregation, etc) but as this is a special case I'm not sure it's worth the implementation complexity. Any thoughts?
   
   yes, but the basic issue is that when you only have one federated location, should i initialize as a row or a col?
   Currently this dilemma results in scenarios where the data is aggregated from the federated sites when we have one worker.
   
   I don't intend to optimize particularly for it, but with this addition we are able to leverage both our row and col optimized operations in this special case with not to much extra code.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org