[GitHub] [zookeeper] Hinterwaeldlers commented on pull request #1391: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

[GitBox <gi...@apache.org>]

Hinterwaeldlers commented on pull request #1391:
URL: https://github.com/apache/zookeeper/pull/1391#issuecomment-658246185


   I was checking your solution @maoling and it seems to work too. Not sure if there are no side effects, from not keeping the zxid in sync, but if it works, it might be the better solution
   
   Related to the change from Follower to leader. I wasn't able to get the whole code yet, but as far as I understood:
   - The follower is not responsible for setting the next zxid, so it's actual value doesn't matter
   - After the leader is lost, there is a short period where no answers are sent out and a new leader is elected
   - When the leader is started, it will start loading the data and set the zxid accordingly
   So there shouldn't a problem here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org