[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1571: Replace &Option with Option<&T>

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #1571:
URL: https://github.com/apache/arrow-rs/pull/1571#discussion_r851645160


##########
parquet/src/file/metadata.rs:
##########
@@ -139,8 +139,8 @@ impl FileMetaData {
     /// ```shell
     /// parquet-mr version 1.8.0 (build 0fda28af84b9746396014ad6a415b90592a98b3b)
     /// ```
-    pub fn created_by(&self) -> &Option<String> {
-        &self.created_by
+    pub fn created_by(&self) -> Option<&String> {

Review Comment:
   ```suggestion
       pub fn created_by(&self) -> Option<&str> {
   ```
   
   Possibly? 



##########
arrow/src/compute/kernels/boolean.rs:
##########
@@ -1010,7 +1010,7 @@ mod tests {
         let expected = BooleanArray::from(vec![false, false, false, false]);
 
         assert_eq!(expected, res);
-        assert_eq!(&None, res.data_ref().null_bitmap());
+        assert_eq!(None, res.data_ref().null_bitmap());

Review Comment:
   ❤️ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org