[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8398: Dynamic adjustment of the orientation and offset to support orientati…

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8398:
URL: https://github.com/apache/nuttx/pull/8398#discussion_r1093252056


##########
drivers/lcd/st7789.c:
##########
@@ -80,16 +80,20 @@
       defined(CONFIG_LCD_RPORTRAIT)
 #    error "Cannot define both portrait and any other orientations"
 #  endif
+#  define LCD_STDORIENTATION LCD_PORTRAIT
 #elif defined(CONFIG_LCD_RPORTRAIT)
 #  if defined(CONFIG_LCD_LANDSCAPE) || defined(CONFIG_LCD_RLANDSCAPE)
 #    error "Cannot define both rportrait and any other orientations"
 #  endif
+#  define LCD_STDORIENTATION LCD_RPORTRAIT
 #elif defined(CONFIG_LCD_LANDSCAPE)
 #  ifdef CONFIG_LCD_RLANDSCAPE
 #    error "Cannot define both landscape and any other orientations"
 #  endif
+#  define LCD_STDORIENTATION LCD_LANDSCAPE
 #elif !defined(CONFIG_LCD_RLANDSCAPE)
 #  define CONFIG_LCD_LANDSCAPE 1
+#  define LCD_STDORIENTATION LCD_RLANDSCAPE

Review Comment:
   If caller pass in orientation, why we keep LCD_STDORIENTATION?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org