Re: svn commit: r1045337 - /ofbiz/trunk/framework/widget/dtd/widget-screen.xsd

[Scott Gray <sc...@hotwaxmedia.com>]

Hi Erwan,

Why force the "parameters" map?  It seems a bit unnecessary and restricts the scope of where the variable can be retrieved from.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 14/12/2010, at 8:44 AM, erwan@apache.org wrote:

> Author: erwan
> Date: Mon Dec 13 19:44:54 2010
> New Revision: 1045337
> 
> URL: http://svn.apache.org/viewvc?rev=1045337&view=rev
> Log:
> Adding enumerations for the conf-mode and use-private elements. Those are used for include-portal-page. This way we can use the parameters and the file is still valid
> 
> Modified:
>    ofbiz/trunk/framework/widget/dtd/widget-screen.xsd
> 
> Modified: ofbiz/trunk/framework/widget/dtd/widget-screen.xsd
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-screen.xsd?rev=1045337&r1=1045336&r2=1045337&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/widget/dtd/widget-screen.xsd (original)
> +++ ofbiz/trunk/framework/widget/dtd/widget-screen.xsd Mon Dec 13 19:44:54 2010
> @@ -1101,6 +1101,7 @@ under the License.
>                 <xs:restriction base="xs:token">
>                     <xs:enumeration value="true"/>
>                     <xs:enumeration value="false"/>
> +                    <xs:enumeration value="${parameters.confMode}"/>
>                 </xs:restriction>
>             </xs:simpleType>
>         </xs:attribute>
> @@ -1110,6 +1111,7 @@ under the License.
>                 <xs:restriction base="xs:token">
>                     <xs:enumeration value="true"/>
>                     <xs:enumeration value="false"/>
> +                    <xs:enumeration value="${parameters.usePrivate}"/>
>                 </xs:restriction>
>             </xs:simpleType>
>         </xs:attribute>
> 
>