You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/14 03:11:33 UTC

[GitHub] [apisix] tzssangglass commented on a change in pull request #5046: chore(debug-mode): move 'enable_debug' form config.yaml to debug.yaml

tzssangglass commented on a change in pull request #5046:
URL: https://github.com/apache/apisix/pull/5046#discussion_r707874607



##########
File path: conf/debug.yaml
##########
@@ -14,6 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+enable_debug: false

Review comment:
       Looks better, but this `enable` will conflict with https://github.com/apache/apisix/blob/b52f95b53c689cfd2fd0f4cbf0fefedd4cce9b5e/t/debug/hook.t#L34
   
   I don't know how to modify this with perl.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org