[GitHub] [kafka] hachikuji commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

[GitBox <gi...@apache.org>]

hachikuji commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418741006



##########
File path: core/src/test/scala/unit/kafka/security/authorizer/AclEntryTest.scala
##########
@@ -23,27 +23,28 @@ import org.apache.kafka.common.acl.AclOperation.READ
 import org.apache.kafka.common.acl.AclPermissionType.{ALLOW, DENY}
 import org.apache.kafka.common.security.auth.KafkaPrincipal
 import org.junit.{Assert, Test}
-import org.scalatestplus.junit.JUnitSuite
 
-import scala.jdk.CollectionConverters._
+import scala.collection.JavaConverters._

Review comment:
       Need to revert this. It is causing the build to fail.

##########
File path: core/src/main/scala/kafka/utils/Json.scala
##########
@@ -35,16 +35,7 @@ object Json {
    */
   def parseFull(input: String): Option[JsonValue] =

Review comment:
       I'm probably missing something obvious, but I found the following callers of this function: `DeleteRecordsCommand`, `LeaderElectionCommand`, `PreferredReplicaLeaderElectionCommand`, and `ReassignPartitionsCommand`. As far as I can tell, none of these uses involve the parsing of ACLs. Did we lose this compatibility handling at some point or is there some magic invocation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org