You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mathias Broekelmann (JIRA)" <my...@incubator.apache.org> on 2005/04/07 12:07:38 UTC

[jira] Created: (MYFACES-174) UIData.isAllChildrenAndFacetsValid() resets the rowindex to -1. x:columns component not working

UIData.isAllChildrenAndFacetsValid() resets the rowindex to -1. x:columns component not working
-----------------------------------------------------------------------------------------------

         Key: MYFACES-174
         URL: http://issues.apache.org/jira/browse/MYFACES-174
     Project: MyFaces
        Type: Bug
    Versions: Nightly Build    
    Reporter: Mathias Broekelmann


UIData.isAllChildrenAndFacetsValid() resets the rowindex to -1 which prevents x:columns component to work right. The example application for the crosstable doesn´t work when a new column is added or the values are modified.

Here is a fix which will set the rowindex to it´s previous value:

Index: UIData.java
===================================================================
RCS file: /home/cvspublic/incubator-myfaces/src/jsfapi/javax/faces/component/UIData.java,v
retrieving revision 1.30
diff -u -r1.30 UIData.java
--- UIData.java	24 Mar 2005 16:46:02 -0000	1.30
+++ UIData.java	7 Apr 2005 09:47:28 -0000
@@ -627,6 +627,7 @@
 		{
 			last = first + rows;
 		}
+	        int setRowIndex = getRowIndex();
 		try
 		{
 			for (int rowIndex = first; rowIndex < last; rowIndex++)
@@ -643,7 +644,7 @@
 		}
 		finally
 		{
-			setRowIndex(-1);
+			setRowIndex(setRowIndex);
 		}
 		return true;
 	}



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (MYFACES-174) UIData.isAllChildrenAndFacetsValid() resets the rowindex to -1. x:columns component not working

Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-174?page=history ]
     
sean schofield resolved MYFACES-174:
------------------------------------

     Resolution: Fixed
    Fix Version: Nightly Build

Patch applied to nightly build.

> UIData.isAllChildrenAndFacetsValid() resets the rowindex to -1. x:columns component not working
> -----------------------------------------------------------------------------------------------
>
>          Key: MYFACES-174
>          URL: http://issues.apache.org/jira/browse/MYFACES-174
>      Project: MyFaces
>         Type: Bug
>     Versions: Nightly Build
>     Reporter: Mathias Broekelmann
>     Assignee: Matthias Weßendorf
>      Fix For: Nightly Build

>
> UIData.isAllChildrenAndFacetsValid() resets the rowindex to -1 which prevents x:columns component to work right. The example application for the crosstable doesn´t work when a new column is added or the values are modified.
> Here is a fix which will set the rowindex to it´s previous value:
> Index: UIData.java
> ===================================================================
> RCS file: /home/cvspublic/incubator-myfaces/src/jsfapi/javax/faces/component/UIData.java,v
> retrieving revision 1.30
> diff -u -r1.30 UIData.java
> --- UIData.java	24 Mar 2005 16:46:02 -0000	1.30
> +++ UIData.java	7 Apr 2005 09:47:28 -0000
> @@ -627,6 +627,7 @@
>  		{
>  			last = first + rows;
>  		}
> +	        int setRowIndex = getRowIndex();
>  		try
>  		{
>  			for (int rowIndex = first; rowIndex < last; rowIndex++)
> @@ -643,7 +644,7 @@
>  		}
>  		finally
>  		{
> -			setRowIndex(-1);
> +			setRowIndex(setRowIndex);
>  		}
>  		return true;
>  	}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira