You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Oliver Deak (JIRA)" <ji...@apache.org> on 2010/08/18 17:13:18 UTC
[jira] Created: (KARAF-143) Setting "karaf.instances" system
property has no effect
Setting "karaf.instances" system property has no effect
-------------------------------------------------------
Key: KARAF-143
URL: https://issues.apache.org/jira/browse/KARAF-143
Project: Karaf
Issue Type: Bug
Affects Versions: 2.0.0
Reporter: Oliver Deak
Priority: Minor
Fix For: 2.2.0
I'm trying to separate the static files from the dynamic ones in a karaf deployment but setting the "karaf.instances" system property is ignored (karaf 2.0.0).
This is because in Main.java on line 191, validate=false when calling Utils.getKarafDirectory(...) so it always revert to the default
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-143) Setting "karaf.instances" system
property has no effect
Posted by "Oliver Deak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900676#action_12900676 ]
Oliver Deak commented on KARAF-143:
-----------------------------------
As for Utils.getKarafDirectory(), a simple fix would be to just do "new File(path)" if validate == false for both the system property and env variable cases. Other than that I don't see much use in the case "validate == false && create == true"...
> Setting "karaf.instances" system property has no effect
> -------------------------------------------------------
>
> Key: KARAF-143
> URL: https://issues.apache.org/jira/browse/KARAF-143
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Oliver Deak
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: KARAF-143.patch
>
>
> I'm trying to separate the static files from the dynamic ones in a karaf deployment but setting the "karaf.instances" system property is ignored (karaf 2.0.0).
> This is because in Main.java on line 191, validate=false when calling Utils.getKarafDirectory(...) so it always revert to the default
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-143) Setting "karaf.instances" system
property has no effect
Posted by "Oliver Deak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900672#action_12900672 ]
Oliver Deak commented on KARAF-143:
-----------------------------------
Indeed, the getKarafDirectory method does not honor the validate parameter properly. However, why would you not want to validate the instances directory? Unless, of course, it would be possible to completely disable the admin functionality so that no instance.properties file gets written.
> Setting "karaf.instances" system property has no effect
> -------------------------------------------------------
>
> Key: KARAF-143
> URL: https://issues.apache.org/jira/browse/KARAF-143
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Oliver Deak
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: KARAF-143.patch
>
>
> I'm trying to separate the static files from the dynamic ones in a karaf deployment but setting the "karaf.instances" system property is ignored (karaf 2.0.0).
> This is because in Main.java on line 191, validate=false when calling Utils.getKarafDirectory(...) so it always revert to the default
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-143) Setting "karaf.instances" system
property has no effect
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900294#action_12900294 ]
Guillaume Nodet commented on KARAF-143:
---------------------------------------
I think the patch is wrong. The arguments are correct, but the getKarafDirectory method is bugged.
> Setting "karaf.instances" system property has no effect
> -------------------------------------------------------
>
> Key: KARAF-143
> URL: https://issues.apache.org/jira/browse/KARAF-143
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Oliver Deak
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: KARAF-143.patch
>
>
> I'm trying to separate the static files from the dynamic ones in a karaf deployment but setting the "karaf.instances" system property is ignored (karaf 2.0.0).
> This is because in Main.java on line 191, validate=false when calling Utils.getKarafDirectory(...) so it always revert to the default
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-143) Setting "karaf.instances" system
property has no effect
Posted by "Oliver Deak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deak updated KARAF-143:
------------------------------
Attachment: KARAF-143.patch
> Setting "karaf.instances" system property has no effect
> -------------------------------------------------------
>
> Key: KARAF-143
> URL: https://issues.apache.org/jira/browse/KARAF-143
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Oliver Deak
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: KARAF-143.patch
>
>
> I'm trying to separate the static files from the dynamic ones in a karaf deployment but setting the "karaf.instances" system property is ignored (karaf 2.0.0).
> This is because in Main.java on line 191, validate=false when calling Utils.getKarafDirectory(...) so it always revert to the default
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (KARAF-143) Setting "karaf.instances" system
property has no effect
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved KARAF-143.
-----------------------------------
Resolution: Fixed
Committing to https://svn.apache.org/repos/asf/karaf/trunk ...
M main/src/main/java/org/apache/karaf/main/Utils.java
Committed r995584
> Setting "karaf.instances" system property has no effect
> -------------------------------------------------------
>
> Key: KARAF-143
> URL: https://issues.apache.org/jira/browse/KARAF-143
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Oliver Deak
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: KARAF-143.patch
>
>
> I'm trying to separate the static files from the dynamic ones in a karaf deployment but setting the "karaf.instances" system property is ignored (karaf 2.0.0).
> This is because in Main.java on line 191, validate=false when calling Utils.getKarafDirectory(...) so it always revert to the default
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (KARAF-143) Setting "karaf.instances" system
property has no effect
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reassigned KARAF-143:
-------------------------------------
Assignee: Guillaume Nodet
> Setting "karaf.instances" system property has no effect
> -------------------------------------------------------
>
> Key: KARAF-143
> URL: https://issues.apache.org/jira/browse/KARAF-143
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Oliver Deak
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: KARAF-143.patch
>
>
> I'm trying to separate the static files from the dynamic ones in a karaf deployment but setting the "karaf.instances" system property is ignored (karaf 2.0.0).
> This is because in Main.java on line 191, validate=false when calling Utils.getKarafDirectory(...) so it always revert to the default
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.