DO NOT REPLY [Bug 19812] New: - BaseFieldTag don't use ConvertUtils as String output formatting

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19812>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19812

BaseFieldTag don't use ConvertUtils as String output formatting

           Summary: BaseFieldTag don't use ConvertUtils as String output
                    formatting
           Product: Struts
           Version: 1.1 RC1
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Custom Tags
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: km.tong@pacso.com


As the tag value does not necessariliy output by .toString() method, such as
Date object.  I think it would be better to call a converter to do the
Object-to-String output formatting and let the developer decide to load a
Converter by ConvertUtils.

Below is my little patch.

Index: src/share/org/apache/struts/taglib/html/BaseFieldTag.java
===================================================================
RCS file:
/home/cvspublic/jakarta-struts/src/share/org/apache/struts/taglib/html/BaseFieldTag.java,v
retrieving revision 1.17
diff -r1.17 BaseFieldTag.java
66a67
> import org.apache.commons.beanutils.ConvertUtils;
179c180
<             results.append(ResponseUtils.filter(value.toString()));
---
>             results.append(ResponseUtils.filter(ConvertUtils.convert(value)));

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org