You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/12/11 09:44:05 UTC

Review Request 41246: Enabled slave get USAGE_SLACK metrics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41246/
-----------------------------------------------------------

Review request for mesos and Klaus Ma.


Bugs: MESOS-4123
    https://issues.apache.org/jira/browse/MESOS-4123


Repository: mesos


Description
-------

Enabled slave get USAGE_SLACK metrics.


Diffs
-----

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41246/diff/


Testing
-------


Thanks,

Guangya Liu


Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41246/
-----------------------------------------------------------

(Updated 一月 23, 2016, 6:10 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.


Bugs: MESOS-4123
    https://issues.apache.org/jira/browse/MESOS-4123


Repository: mesos


Description
-------

Enabled slave get USAGE_SLACK metrics.


Diffs (updated)
-----

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 1bd973a9cf4d8b922db9bd2f3df93bad7cc743bb 
  src/tests/metrics_tests.cpp 106bea58b0714ae745df73597c702e4815523938 

Diff: https://reviews.apache.org/r/41246/diff/


Testing
-------

$ curl "http://192.168.0.107:5051/metrics/snapshot" 2>/dev/null| jq . | grep usage_slack
  "slave/cpus_usage_slack_percent": 0,
  "slave/cpus_usage_slack_total": 0,
  "slave/cpus_usage_slack_used": 0,
  "slave/disk_usage_slack_percent": 0,
  "slave/disk_usage_slack_total": 0,
  "slave/disk_usage_slack_used": 0,
  "slave/mem_usage_slack_percent": 0,
  "slave/mem_usage_slack_total": 0,
  "slave/mem_usage_slack_used": 0,


Thanks,

Guangya Liu


Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41246/
-----------------------------------------------------------

(Updated 一月 3, 2016, 1:31 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.


Bugs: MESOS-4123
    https://issues.apache.org/jira/browse/MESOS-4123


Repository: mesos


Description
-------

Enabled slave get USAGE_SLACK metrics.


Diffs (updated)
-----

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
  src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 

Diff: https://reviews.apache.org/r/41246/diff/


Testing (updated)
-------

$ curl "http://192.168.0.107:5051/metrics/snapshot" 2>/dev/null| jq . | grep usage_slack
  "slave/cpus_usage_slack_percent": 0,
  "slave/cpus_usage_slack_total": 0,
  "slave/cpus_usage_slack_used": 0,
  "slave/disk_usage_slack_percent": 0,
  "slave/disk_usage_slack_total": 0,
  "slave/disk_usage_slack_used": 0,
  "slave/mem_usage_slack_percent": 0,
  "slave/mem_usage_slack_total": 0,
  "slave/mem_usage_slack_used": 0,


Thanks,

Guangya Liu


Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41246/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 6:48 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.


Bugs: MESOS-4123
    https://issues.apache.org/jira/browse/MESOS-4123


Repository: mesos


Description
-------

Enabled slave get USAGE_SLACK metrics.


Diffs (updated)
-----

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41246/diff/


Testing
-------

$ curl "http://192.168.0.107:5051/metrics/snapshot" 2>/dev/null| jq . | grep usage_slack
  "slave/cpus_usage_slack_revocable_percent": 0,
  "slave/cpus_usage_slack_revocable_total": 0,
  "slave/cpus_usage_slack_revocable_used": 0,
  "slave/disk_usage_slack_revocable_percent": 0,
  "slave/disk_usage_slack_revocable_total": 0,
  "slave/disk_usage_slack_revocable_used": 0,
  "slave/mem_usage_slack_revocable_percent": 0,
  "slave/mem_usage_slack_revocable_total": 0,
  "slave/mem_usage_slack_revocable_used": 0,


Thanks,

Guangya Liu


Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41246/
-----------------------------------------------------------

(Updated 十二月 12, 2015, 4:43 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.


Bugs: MESOS-4123
    https://issues.apache.org/jira/browse/MESOS-4123


Repository: mesos


Description
-------

Enabled slave get USAGE_SLACK metrics.


Diffs (updated)
-----

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41246/diff/


Testing
-------

$ curl "http://192.168.0.107:5051/metrics/snapshot" 2>/dev/null| jq . | grep usage_slack
  "slave/cpus_usage_slack_revocable_percent": 0,
  "slave/cpus_usage_slack_revocable_total": 0,
  "slave/cpus_usage_slack_revocable_used": 0,
  "slave/disk_usage_slack_revocable_percent": 0,
  "slave/disk_usage_slack_revocable_total": 0,
  "slave/disk_usage_slack_revocable_used": 0,
  "slave/mem_usage_slack_revocable_percent": 0,
  "slave/mem_usage_slack_revocable_total": 0,
  "slave/mem_usage_slack_revocable_used": 0,


Thanks,

Guangya Liu


Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41246/
-----------------------------------------------------------

(Updated 十二月 11, 2015, 8:50 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.


Bugs: MESOS-4123
    https://issues.apache.org/jira/browse/MESOS-4123


Repository: mesos


Description
-------

Enabled slave get USAGE_SLACK metrics.


Diffs
-----

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41246/diff/


Testing (updated)
-------

$ curl "http://192.168.0.107:5051/metrics/snapshot" 2>/dev/null| jq . | grep usage_slack
  "slave/cpus_usage_slack_revocable_percent": 0,
  "slave/cpus_usage_slack_revocable_total": 0,
  "slave/cpus_usage_slack_revocable_used": 0,
  "slave/disk_usage_slack_revocable_percent": 0,
  "slave/disk_usage_slack_revocable_total": 0,
  "slave/disk_usage_slack_revocable_used": 0,
  "slave/mem_usage_slack_revocable_percent": 0,
  "slave/mem_usage_slack_revocable_total": 0,
  "slave/mem_usage_slack_revocable_used": 0,


Thanks,

Guangya Liu