You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2016/12/12 22:11:44 UTC
Re: Review Request 52765: Populated `recovered_slaves` in `/state` and
`/slaves` endpoints.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review158902
-----------------------------------------------------------
Sorry for the delay on this.
As per our offline discussion, can you also make the `Summary<Slave>&` helper use the new writer overload you added in a separate patch?
src/master/http.cpp (line 158)
<https://reviews.apache.org/r/52765/#comment229721>
Any reason for not adding `port` here?
src/master/http.cpp (line 2309)
<https://reviews.apache.org/r/52765/#comment229722>
Let's keep the same comment here as you have on L2688 later
- Anand Mazumdar
On Nov. 2, 2016, 4:42 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2016, 4:42 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
>
>
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40
> src/tests/master_tests.cpp ce42a106e8c671c9eaddb85d45153f31e0b9a488
>
> Diff: https://reviews.apache.org/r/52765/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 52765: Populated `recovered_slaves` in `/state` and
`/slaves` endpoints.
Posted by Zhitao Li <zh...@gmail.com>.
> On Dec. 12, 2016, 10:11 p.m., Anand Mazumdar wrote:
> > src/master/http.cpp, line 158
> > <https://reviews.apache.org/r/52765/diff/5/?file=1551621#file1551621line158>
> >
> > Any reason for not adding `port` here?
It was never added in the past. I will add it in this patch.
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review158902
-----------------------------------------------------------
On Dec. 14, 2016, 4:48 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 4:48 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
>
>
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac
> src/tests/master_tests.cpp b3b5630899082a69119d2cccb6460766d1352963
>
> Diff: https://reviews.apache.org/r/52765/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>