You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (JIRA)" <ji...@apache.org> on 2012/08/17 02:17:38 UTC

[jira] [Created] (HIVE-3393) get_json_object and json_tuple should use Jackson library

Kevin Wilfong created HIVE-3393:
-----------------------------------

             Summary: get_json_object and json_tuple should use Jackson library
                 Key: HIVE-3393
                 URL: https://issues.apache.org/jira/browse/HIVE-3393
             Project: Hive
          Issue Type: Improvement
          Components: UDF
    Affects Versions: 0.10.0
            Reporter: Kevin Wilfong
            Assignee: Kevin Wilfong
            Priority: Minor


The Jackson library's JSON parsers have been shown to be significantly faster that json.org's.  The library is already included, so I can't think of a reason not to use it.

There's also the potential for further improvements in replacing many of the try catch blocks with if statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-3393) get_json_object and json_tuple should use Jackson library

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-3393:
--------------------------------

    Attachment: HIVE-3393.1.patch.txt
    
> get_json_object and json_tuple should use Jackson library
> ---------------------------------------------------------
>
>                 Key: HIVE-3393
>                 URL: https://issues.apache.org/jira/browse/HIVE-3393
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>            Priority: Minor
>         Attachments: HIVE-3393.1.patch.txt
>
>
> The Jackson library's JSON parsers have been shown to be significantly faster that json.org's.  The library is already included, so I can't think of a reason not to use it.
> There's also the potential for further improvements in replacing many of the try catch blocks with if statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-3393) get_json_object and json_tuple should use Jackson library

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-3393:
-----------------------------------

    Fix Version/s: 0.10.0
    
> get_json_object and json_tuple should use Jackson library
> ---------------------------------------------------------
>
>                 Key: HIVE-3393
>                 URL: https://issues.apache.org/jira/browse/HIVE-3393
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3393.1.patch.txt
>
>
> The Jackson library's JSON parsers have been shown to be significantly faster that json.org's.  The library is already included, so I can't think of a reason not to use it.
> There's also the potential for further improvements in replacing many of the try catch blocks with if statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3393) get_json_object and json_tuple should use Jackson library

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436466#comment-13436466 ] 

Kevin Wilfong commented on HIVE-3393:
-------------------------------------

Uploaded a diff here https://reviews.facebook.net/D4701
                
> get_json_object and json_tuple should use Jackson library
> ---------------------------------------------------------
>
>                 Key: HIVE-3393
>                 URL: https://issues.apache.org/jira/browse/HIVE-3393
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>            Priority: Minor
>         Attachments: HIVE-3393.1.patch.txt
>
>
> The Jackson library's JSON parsers have been shown to be significantly faster that json.org's.  The library is already included, so I can't think of a reason not to use it.
> There's also the potential for further improvements in replacing many of the try catch blocks with if statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-3393) get_json_object and json_tuple should use Jackson library

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-3393:
--------------------------------

    Status: Patch Available  (was: Open)
    
> get_json_object and json_tuple should use Jackson library
> ---------------------------------------------------------
>
>                 Key: HIVE-3393
>                 URL: https://issues.apache.org/jira/browse/HIVE-3393
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>            Priority: Minor
>         Attachments: HIVE-3393.1.patch.txt
>
>
> The Jackson library's JSON parsers have been shown to be significantly faster that json.org's.  The library is already included, so I can't think of a reason not to use it.
> There's also the potential for further improvements in replacing many of the try catch blocks with if statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-3393) get_json_object and json_tuple should use Jackson library

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446094#comment-13446094 ] 

Hudson commented on HIVE-3393:
------------------------------

Integrated in Hive-trunk-h0.21 #1638 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1638/])
    HIVE-3393 get_json_object and json_tuple should use Jackson library
(Kevin Wilfong via namit) (Revision 1379313)

     Result = FAILURE
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379313
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java
* /hive/trunk/ql/src/test/results/clientpositive/udf_get_json_object.q.out

                
> get_json_object and json_tuple should use Jackson library
> ---------------------------------------------------------
>
>                 Key: HIVE-3393
>                 URL: https://issues.apache.org/jira/browse/HIVE-3393
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3393.1.patch.txt
>
>
> The Jackson library's JSON parsers have been shown to be significantly faster that json.org's.  The library is already included, so I can't think of a reason not to use it.
> There's also the potential for further improvements in replacing many of the try catch blocks with if statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3393) get_json_object and json_tuple should use Jackson library

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3393:
-----------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Committed. Thanks Kevin
                
> get_json_object and json_tuple should use Jackson library
> ---------------------------------------------------------
>
>                 Key: HIVE-3393
>                 URL: https://issues.apache.org/jira/browse/HIVE-3393
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>            Priority: Minor
>         Attachments: HIVE-3393.1.patch.txt
>
>
> The Jackson library's JSON parsers have been shown to be significantly faster that json.org's.  The library is already included, so I can't think of a reason not to use it.
> There's also the potential for further improvements in replacing many of the try catch blocks with if statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3393) get_json_object and json_tuple should use Jackson library

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445724#comment-13445724 ] 

Namit Jain commented on HIVE-3393:
----------------------------------

+1
                
> get_json_object and json_tuple should use Jackson library
> ---------------------------------------------------------
>
>                 Key: HIVE-3393
>                 URL: https://issues.apache.org/jira/browse/HIVE-3393
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 0.10.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>            Priority: Minor
>         Attachments: HIVE-3393.1.patch.txt
>
>
> The Jackson library's JSON parsers have been shown to be significantly faster that json.org's.  The library is already included, so I can't think of a reason not to use it.
> There's also the potential for further improvements in replacing many of the try catch blocks with if statements.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira