You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/15 03:20:11 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
nsivabalan opened a new pull request #5043:
URL: https://github.com/apache/hudi/pull/5043
## What is the purpose of the pull request
Users can configure spark scheduler configs for async clustering service with this patch.
## Brief change log
- Added new configs to DeltaStreamer to set clustering scheduler configs. "clusterSchedulingWeight" and "clusterSchedulingMinShare".
## Verify this pull request
- Verified locally.
<img width="1772" alt="Screen Shot 2022-03-14 at 8 09 24 PM" src="https://user-images.githubusercontent.com/513218/158299422-80a6eb0b-90a3-4b47-964a-9bc6b029628a.png">
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #5043:
URL: https://github.com/apache/hudi/pull/5043#discussion_r838034087
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -388,6 +388,14 @@ private boolean onDeltaSyncShutdown(boolean error) {
@Parameter(names = {"--retry-last-pending-inline-clustering", "-rc"}, description = "Retry last pending inline clustering plan before writing to sink.")
public Boolean retryLastPendingInlineClusteringJob = false;
+ @Parameter(names = {"--cluster-scheduling-weight"}, description = "Scheduling weight for clustering as defined in "
+ + "https://spark.apache.org/docs/latest/job-scheduling.html")
+ public Integer clusterSchedulingWeight = 1;
Review comment:
will sync up with you directly. but on a high level, this depends on lot of factors. may be we can create a tracking ticket and do a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5043:
URL: https://github.com/apache/hudi/pull/5043#issuecomment-1067521603
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd6395662004c77ebaba17448ce829f821675b3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd6395662004c77ebaba17448ce829f821675b3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd6395662004c77ebaba17448ce829f821675b3b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #5043:
URL: https://github.com/apache/hudi/pull/5043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5043:
URL: https://github.com/apache/hudi/pull/5043#issuecomment-1067521603
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd6395662004c77ebaba17448ce829f821675b3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd6395662004c77ebaba17448ce829f821675b3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd6395662004c77ebaba17448ce829f821675b3b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5043:
URL: https://github.com/apache/hudi/pull/5043#issuecomment-1067559671
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd6395662004c77ebaba17448ce829f821675b3b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6951",
"triggerID" : "dd6395662004c77ebaba17448ce829f821675b3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd6395662004c77ebaba17448ce829f821675b3b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6951)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5043:
URL: https://github.com/apache/hudi/pull/5043#issuecomment-1067522880
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd6395662004c77ebaba17448ce829f821675b3b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6951",
"triggerID" : "dd6395662004c77ebaba17448ce829f821675b3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd6395662004c77ebaba17448ce829f821675b3b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6951)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #5043:
URL: https://github.com/apache/hudi/pull/5043#discussion_r837068928
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -388,6 +388,14 @@ private boolean onDeltaSyncShutdown(boolean error) {
@Parameter(names = {"--retry-last-pending-inline-clustering", "-rc"}, description = "Retry last pending inline clustering plan before writing to sink.")
public Boolean retryLastPendingInlineClusteringJob = false;
+ @Parameter(names = {"--cluster-scheduling-weight"}, description = "Scheduling weight for clustering as defined in "
+ + "https://spark.apache.org/docs/latest/job-scheduling.html")
+ public Integer clusterSchedulingWeight = 1;
Review comment:
Just a thought, does it make sense to determine the clustering and compaction weight depending on their commit frequency ratio?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5043: [HUDI-3485] Adding scheduler pool configs for async clustering
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5043:
URL: https://github.com/apache/hudi/pull/5043#issuecomment-1067522880
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd6395662004c77ebaba17448ce829f821675b3b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6951",
"triggerID" : "dd6395662004c77ebaba17448ce829f821675b3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd6395662004c77ebaba17448ce829f821675b3b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6951)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org