You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/30 04:17:26 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request #1620: [CI]Merged PR should be after basic CI check passes
CalvinKirs opened a new pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620
For some unstable CI, I don't make limit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1620: [CI]Merged PR should be after basic CI check passes
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r838411527
##########
File path: .asf.yaml
##########
@@ -35,6 +35,12 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
Review comment:
There is a problem, for some PRs, it only needs to run a part of CI, and here we limit these jobs confirm to be successful, then there may be problems at this time and it cannot be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1620: [CI]Merged PR should be after basic CI check passes
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r838310703
##########
File path: .asf.yaml
##########
@@ -35,6 +35,13 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
+ - Spark
+ - Build (8)
+ - Build (11)
Review comment:
Thx, done,PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on a change in pull request #1620: [CI]Merged PR should be after basic CI check passes
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r839107401
##########
File path: .asf.yaml
##########
@@ -35,6 +35,12 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
Review comment:
Yeah, you're right, maybe we should find some way to mark these checks as success when they were skipped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on a change in pull request #1620: [CI]Merged PR should be after basic CI check passes
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r838148047
##########
File path: .asf.yaml
##########
@@ -35,6 +35,13 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
Review comment:
I get this, and close it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on a change in pull request #1620: [CI]Merged PR should be after basic CI check passes
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r838313641
##########
File path: .asf.yaml
##########
@@ -35,6 +35,11 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
+ - Spark
Review comment:
You should also add `Backend` to context, otherwise our backend build is not required
```suggestion
- Spark
- Backend
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on a change in pull request #1620: [CI]Merged PR should be after basic CI check passes
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r838140913
##########
File path: .asf.yaml
##########
@@ -35,6 +35,13 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
Review comment:
I find out we have lot of ci job named `Build` should we first rename them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on a change in pull request #1620: [CI]Merged PR should be after basic CI check passes
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r838144668
##########
File path: .asf.yaml
##########
@@ -35,6 +35,13 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
Review comment:
Oh, I got it, this build is for auto license, and the others is in`Build (8)` and `Build (11)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on a change in pull request #1620: [CI]Merged PR should be after basic CI check passes
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #1620:
URL: https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r838147769
##########
File path: .asf.yaml
##########
@@ -35,6 +35,13 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
+ - Spark
+ - Build (8)
+ - Build (11)
Review comment:
I think we should add the final step to determine all versions build success, it will make our CI rubust because we may add other JDK supported. You could find examples inhttps://github.com/apache/dolphinscheduler/blob/dev/.github/workflows/e2e.yml#L141-L154. Others look good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org