[GitHub] [cloudstack] rhtyd commented on a change in pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#discussion_r381890199
 
 

 ##########
 File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 ##########
 @@ -423,6 +427,12 @@ public void allocate(final String vmInstanceName, final VirtualMachineTemplate t
 
         final VirtualMachineProfileImpl vmProfile = new VirtualMachineProfileImpl(vmFinal, template, serviceOffering, null, null);
 
+        Long rootDiskSize = rootDiskOfferingInfo.getSize();
+        if (vm.getType().isUsedBySystem() && SystemVmRootDiskSize.value() != null) {
 
 Review comment:
   should there be a value/size check `> 0`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services