[GitHub] [hbase] thangTang commented on a diff in pull request #4999: HBASE-27599 Add version of hadoop-common test jar

["thangTang (via GitHub)" <gi...@apache.org>]

thangTang commented on code in PR #4999:
URL: https://github.com/apache/hbase/pull/4999#discussion_r1091406825


##########
hbase-shaded/hbase-shaded-testing-util/pom.xml:
##########
@@ -151,6 +151,7 @@
         <dependency>
           <groupId>org.apache.hadoop</groupId>
           <artifactId>hadoop-common</artifactId>
+          <version>${hadoop.version}</version>

Review Comment:
   > We should add the version in dependencyManagement section in the parent pom?
   
   I tried to add it to root pom but found some other confusion. 
   
   We do have a hadoop-common in dependencyManagement: https://github.com/apache/hbase/blob/8e72cc6ee0415608d2d31e1c0c0175e8fc228d8d/pom.xml#L3918
   But there seems to be a problem with this way of writing. Why do you need to specify both classifier and type? It seems that the correct jar cannot be located with these way. Not only hadoop-common, hadoop-hdfs also has this problem.
   
   So if I'm correct, this seems to be a bug? Should we remove the classifier?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org