You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/01/06 23:37:00 UTC
[GitHub] [incubator-mxnet] ptrendx opened a new pull request #20810: [BUGFIX]Fix the regular expression in RTC code
ptrendx opened a new pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810
## Description ##
This PR makes the regular expression in the legacy RTC code path more efficient.
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Instead of checking for arbitrary number of whitespace character in the regular expression, I strip the input so that only a single whitespace is left between matched groups and modify the regular expression accordingly.
FYI @josephevans @szha @TristonC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
TristonC commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1013488335
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1008328937
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu merged pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
marcoabreu merged pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1007735921
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1007568731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1013488378
Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1007568731
@mxnet-bot run ci [unix-cpu, website, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1007568809
Jenkins CI successfully triggered : [unix-cpu, windows-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1007568809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1013490447
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1008328925
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1013490408
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20810: [BUGFIX]Fix the regular expression in RTC code
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20810:
URL: https://github.com/apache/incubator-mxnet/pull/20810#issuecomment-1007735876
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org