You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/05/22 18:03:07 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #14918: [TIR] SplitHostDevice, handle subroutines
Lunderberg opened a new pull request, #14918:
URL: https://github.com/apache/tvm/pull/14918
This PR refactors `SplitHostDevice` into three separate transformations. Previously, `SplitHostDevice` would replace device regions with a `builtin::tvm_call_packed()` node to replace the extracted region. After this PR, this process is performed in three separate steps.
1. `AnnotateDeviceRegion`: Annotate the regions that should be executed on another target.
2. `SplitHostDevice`: Extract the annotated region into an independent PrimFunc, with a `GlobalVar` to represent the call from into the new subroutine.
3. `LowerDeviceKernelLaunch`: For any subroutine call where the caller and callee are on different devices, replace with a device kernel launch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14918:
URL: https://github.com/apache/tvm/pull/14918#issuecomment-1557666969
This PR is a subset of the functionality in https://github.com/apache/tvm/pull/14862. As that PR has grown to a difficult-to-review size, I'm carving off independent chunks of it into separate PRs, after which #14862 can be rebased to a more manageable size.
In addition, this PR depends on https://github.com/apache/tvm/pull/14915 for the new unit tests, and should be rebased onto main after #14915 lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14918:
URL: https://github.com/apache/tvm/pull/14918#issuecomment-1568526865
Found the issue. It was a combination of this PR and #14945, which is why it wasn't caught by CI. A full description of the issue, and a bugfix, are in PR #14982.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14918:
URL: https://github.com/apache/tvm/pull/14918#issuecomment-1563277263
(Merged https://github.com/apache/tvm/pull/14950 into this PR to allow CI to run. No conflicts expected after CI, so github's squash/merge will remove it from the final commit.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a diff in pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on code in PR #14918:
URL: https://github.com/apache/tvm/pull/14918#discussion_r1205830652
##########
src/tir/transforms/lower_device_kernel_launch.cc:
##########
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file lower_device_kernel_launch.cc
+ * \brief Split device function from host.
+ */
+#include <tvm/ir/transform.h>
+#include <tvm/runtime/registry.h>
+#include <tvm/target/target.h>
+#include <tvm/tir/builtin.h>
+#include <tvm/tir/expr.h>
+#include <tvm/tir/stmt_functor.h>
+#include <tvm/tir/transform.h>
+
+#include "../../runtime/thread_storage_scope.h"
+#include "ir_utils.h"
+
+namespace tvm {
+namespace tir {
+
+namespace {
+struct KernelInfo {
+ // The device on which the PrimFunc runs
+ Target target;
+
+ // The externally visible symbol which may refer to the PrimFunc
+ // when launching a device kernel.
+ String global_symbol;
+
+ // The parameters accepted by the PrimFunc. Used to rewrite
+ // `launch_args` to be in terms of the calling scope.
+ Array<Var> params;
+
+ // The launch parameters that should annotate the PrimFunc, if the
+ // kernel is ever called from the host.
+ Array<String> launch_params;
+
+ // Additional arguments which must be provided to the host-side
+ // PackedFunc. These may be in terms of the function's parameters
+ // (e.g. a function that computes the average of `N` elements, and
+ // which must be launched with `N` CUDA threads).
+ Array<PrimExpr> launch_args;
+};
+
+/*!
+ * \brief Visitor class to collect device-side program information.
+ */
+class DeviceInfoCollector : public StmtVisitor {
+ public:
+ static KernelInfo Collect(const GlobalVar& gvar, const PrimFuncNode* func) {
+ DeviceInfoCollector collector;
+ collector.info_.target = [&]() -> Target {
+ auto target_attr = func->GetAttr<Target>(tvm::attr::kTarget).value();
+ bool is_host_func =
+ func->GetAttr<Bool>(tvm::tir::attr::kIsHostFunc).value_or(Bool(false))->value;
Review Comment:
Agreed, and updated. The `SplitHostDevice` and `LowerDeviceKernelLaunch` no longer use the `kIsHostFunc` attribute at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14918:
URL: https://github.com/apache/tvm/pull/14918#issuecomment-1557665251
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14918:
URL: https://github.com/apache/tvm/pull/14918#issuecomment-1565453422
there seems to be a regression caused by this PR, please look into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan commented on a diff in pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "csullivan (via GitHub)" <gi...@apache.org>.
csullivan commented on code in PR #14918:
URL: https://github.com/apache/tvm/pull/14918#discussion_r1205776286
##########
src/tir/transforms/lower_device_kernel_launch.cc:
##########
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file lower_device_kernel_launch.cc
+ * \brief Split device function from host.
+ */
+#include <tvm/ir/transform.h>
+#include <tvm/runtime/registry.h>
+#include <tvm/target/target.h>
+#include <tvm/tir/builtin.h>
+#include <tvm/tir/expr.h>
+#include <tvm/tir/stmt_functor.h>
+#include <tvm/tir/transform.h>
+
+#include "../../runtime/thread_storage_scope.h"
+#include "ir_utils.h"
+
+namespace tvm {
+namespace tir {
+
+namespace {
+struct KernelInfo {
+ // The device on which the PrimFunc runs
+ Target target;
+
+ // The externally visible symbol which may refer to the PrimFunc
+ // when launching a device kernel.
+ String global_symbol;
+
+ // The parameters accepted by the PrimFunc. Used to rewrite
+ // `launch_args` to be in terms of the calling scope.
+ Array<Var> params;
+
+ // The launch parameters that should annotate the PrimFunc, if the
+ // kernel is ever called from the host.
+ Array<String> launch_params;
+
+ // Additional arguments which must be provided to the host-side
+ // PackedFunc. These may be in terms of the function's parameters
+ // (e.g. a function that computes the average of `N` elements, and
+ // which must be launched with `N` CUDA threads).
+ Array<PrimExpr> launch_args;
+};
+
+/*!
+ * \brief Visitor class to collect device-side program information.
+ */
+class DeviceInfoCollector : public StmtVisitor {
+ public:
+ static KernelInfo Collect(const GlobalVar& gvar, const PrimFuncNode* func) {
+ DeviceInfoCollector collector;
+ collector.info_.target = [&]() -> Target {
+ auto target_attr = func->GetAttr<Target>(tvm::attr::kTarget).value();
+ bool is_host_func =
+ func->GetAttr<Bool>(tvm::tir::attr::kIsHostFunc).value_or(Bool(false))->value;
Review Comment:
Re. discussion offline, do we want to update to not rely on kIsHostFunc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14918:
URL: https://github.com/apache/tvm/pull/14918#issuecomment-1568403605
@tqchen Thank you for the heads up, and looking into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan merged pull request #14918: [TIR] SplitHostDevice, handle subroutines
Posted by "csullivan (via GitHub)" <gi...@apache.org>.
csullivan merged PR #14918:
URL: https://github.com/apache/tvm/pull/14918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TIR] SplitHostDevice, handle subroutines [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14918:
URL: https://github.com/apache/tvm/pull/14918#issuecomment-1855091918
A note that we should revisit some of the assumptions https://github.com/apache/tvm/issues/16237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org