[GitHub] [helix] desaikomal commented on pull request #2478: Add hashCode() to AssignableReplica and fix logic in hash-based collection

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on PR #2478:
URL: https://github.com/apache/helix/pull/2478#issuecomment-1536377891

   @jiajunwang - can you please elaborate on performance concern? From correctness point of view, @qqu0127 seems to be correct? we will have same kind of objects hashed differently.  We have 2 things here:
   (a) Adding 'hashCode' 
   (b) choosing List over Set.
   
   I think (a) is required for correctness. (b) is for performance based on what Quincy has pointed out. Are we in disagreement on (a) or (b) ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org