You are viewing a plain text version of this content. The canonical link for it is here.
Posted to infrastructure-issues@apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2007/12/08 21:21:43 UTC
[jira] Created: (INFRA-1439) UserPreferences page forces use of
question for every change
UserPreferences page forces use of question for every change
------------------------------------------------------------
Key: INFRA-1439
URL: https://issues.apache.org/jira/browse/INFRA-1439
Project: Infrastructure
Issue Type: Bug
Security Level: public (Regular issues)
Components: MoinMoin
Reporter: Sebb
Priority: Minor
The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (INFRA-1439) UserPreferences page forces use of
question for every change
Posted by "Joe Schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564514#action_12564514 ]
Joe Schaefer commented on INFRA-1439:
-------------------------------------
r617239 works great for me. Please close this out
if you are satisfied as well.
> UserPreferences page forces use of question for every change
> ------------------------------------------------------------
>
> Key: INFRA-1439
> URL: https://issues.apache.org/jira/browse/INFRA-1439
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: MoinMoin
> Reporter: Sebb
> Priority: Minor
> Attachments: userform.py.patch
>
>
> The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
> If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (INFRA-1439) UserPreferences page forces use of
question for every change
Posted by "Joe Schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561809#action_12561809 ]
Joe Schaefer commented on INFRA-1439:
-------------------------------------
We need to change the comment to something
more accurate. Suggestions?
> UserPreferences page forces use of question for every change
> ------------------------------------------------------------
>
> Key: INFRA-1439
> URL: https://issues.apache.org/jira/browse/INFRA-1439
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: MoinMoin
> Reporter: Sebb
> Priority: Minor
>
> The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
> If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (INFRA-1439) UserPreferences page forces use of
question for every change
Posted by "Joe Schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563344#action_12563344 ]
Joe Schaefer commented on INFRA-1439:
-------------------------------------
Last time I looked, a patch to behave the way you
want looked rather involved. I think the simplest
thing to do is to change the comment so it matches
the current behavior.
> UserPreferences page forces use of question for every change
> ------------------------------------------------------------
>
> Key: INFRA-1439
> URL: https://issues.apache.org/jira/browse/INFRA-1439
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: MoinMoin
> Reporter: Sebb
> Priority: Minor
>
> The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
> If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (INFRA-1439) UserPreferences page forces use of
question for every change
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564502#action_12564502 ]
Sebb commented on INFRA-1439:
-----------------------------
OK:
commit -m "See: INFRA-1439 - ASK question should only be asked for new logins" D:/eclipseworkspaces/main/MoinMoin/userform.py
Sending D:/eclipseworkspaces/main/MoinMoin/userform.py
Transmitting file data ...
Committed revision 617239.
> UserPreferences page forces use of question for every change
> ------------------------------------------------------------
>
> Key: INFRA-1439
> URL: https://issues.apache.org/jira/browse/INFRA-1439
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: MoinMoin
> Reporter: Sebb
> Priority: Minor
> Attachments: userform.py.patch
>
>
> The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
> If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (INFRA-1439) UserPreferences page forces use of
question for every change
Posted by "Joe Schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564493#action_12564493 ]
Joe Schaefer commented on INFRA-1439:
-------------------------------------
Worth a shot- +1 to commit.
> UserPreferences page forces use of question for every change
> ------------------------------------------------------------
>
> Key: INFRA-1439
> URL: https://issues.apache.org/jira/browse/INFRA-1439
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: MoinMoin
> Reporter: Sebb
> Priority: Minor
> Attachments: userform.py.patch
>
>
> The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
> If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (INFRA-1439) UserPreferences page forces use of
question for every change
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated INFRA-1439:
------------------------
Attachment: userform.py.patch
Proposed patch:
- Second Password also needed when creating accounts
- move ASF query check a bit later where we know if it is a new user or not
> UserPreferences page forces use of question for every change
> ------------------------------------------------------------
>
> Key: INFRA-1439
> URL: https://issues.apache.org/jira/browse/INFRA-1439
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: MoinMoin
> Reporter: Sebb
> Priority: Minor
> Attachments: userform.py.patch
>
>
> The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
> If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (INFRA-1439) UserPreferences page forces use of
question for every change
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb closed INFRA-1439.
-----------------------
Resolution: Fixed
Works for me too. Yay!
> UserPreferences page forces use of question for every change
> ------------------------------------------------------------
>
> Key: INFRA-1439
> URL: https://issues.apache.org/jira/browse/INFRA-1439
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: MoinMoin
> Reporter: Sebb
> Priority: Minor
> Attachments: userform.py.patch
>
>
> The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
> If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (INFRA-1439) UserPreferences page forces use of
question for every change
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561861#action_12561861 ]
Sebb commented on INFRA-1439:
-----------------------------
How about changing it to "(required)" ?
However, I think that it's overkill (and annoying) to require the question for anything other than new accounts.
If others agree, I can look into developing a patch to do that.
> UserPreferences page forces use of question for every change
> ------------------------------------------------------------
>
> Key: INFRA-1439
> URL: https://issues.apache.org/jira/browse/INFRA-1439
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: MoinMoin
> Reporter: Sebb
> Priority: Minor
>
> The UserPreferences page says that the question is "(required for new user accounts)", however, it seems to be required for all updates on that page.
> If that was the intention, perhaps the text could be updated to make this clear, otherwise the question should be skipped unless creating a new account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.