You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 11:17:55 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #11814: [FLINK-17218][tests] Adding recoverable failures and correctness chec…
zhijiangW commented on a change in pull request #11814:
URL: https://github.com/apache/flink/pull/11814#discussion_r425734079
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImpl.java
##########
@@ -91,6 +91,7 @@ public ChannelStateWriterImpl(CheckpointStorageWorkerView streamFactoryResolver)
@Override
public void start(long checkpointId, CheckpointOptions checkpointOptions) {
+ results.keySet().forEach(oldCheckpointId -> abort(oldCheckpointId, new Exception("Starting new checkpoint " + checkpointId)));
Review comment:
I guess the below `Preconditions.checkState(results.size() < maxCheckpoints, "results.size() > maxCheckpoints", results.size(), maxCheckpoints);` might be invalid if we remove the pending ones here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org