You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2016/07/17 08:20:39 UTC
[GitHub] spark pull request #14236: [SPARK-16588][SQL] Missed API fix for a function ...
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/14236
[SPARK-16588][SQL] Missed API fix for a function name mismatched between FunctionRegistry and functions.scala
## What changes were proposed in this pull request?
It seems the function `monotonicallyIncreasingId` was missed in https://issues.apache.org/jira/browse/SPARK-10621
The registered name is [monotonically_increasing_id](https://github.com/apache/spark/blob/56bd399a86c4e92be412d151200cb5e4a5f6a48a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L369) but [monotonicallyIncreasingId](https://github.com/apache/spark/blob/5f342049cce9102fb62b4de2d8d8fa691c2e8ac4/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L981) was still not deprecated and removed.
So, this was also missed in https://issues.apache.org/jira/browse/SPARK-12600 (removing deprecated APIs).
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-16588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14236
----
commit d947be6b039aa3c4744b0be2c06c1bbb4c3500fc
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-07-17T08:17:53Z
Missed API fix for a function name mismatched between FunctionRegistry and functions.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14236: [SPARK-16588][SQL] Missed API fix for a function name mi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14236
FYI, there is one more usage in [ColumnExpressionSuite.scala#L517](https://github.com/apache/spark/blob/46395db80e3304e3f3a1ebdc8aadb8f2819b48b4/sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala#L517) which is dedicated test for this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14236: [SPARK-16588][SQL] Missed API fix for a function name mi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14236
**[Test build #62427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62427/consoleFull)** for PR 14236 at commit [`d947be6`](https://github.com/apache/spark/commit/d947be6b039aa3c4744b0be2c06c1bbb4c3500fc).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14236: [SPARK-16588][SQL] Missed API fix for a function ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14236#discussion_r71101740
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -977,7 +977,10 @@ object functions {
*
* @group normal_funcs
* @since 1.4.0
+ * @deprecated As of 2.0.0, replaced by `monotonically_increasing_id`. This will be removed in
+ * Spark 2.1.
*/
+ @deprecated("Use monotonically_increasing_id. This will be removed in Spark 2.1.", "2.0.0")
--- End diff --
we probably don't want to remove it in 2.1. can you just say "Use monotonically_increasing_id()"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14236: [SPARK-16588][SQL] Missed API fix for a function name mi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14236
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14236: [SPARK-16588][SQL] Missed API fix for a function name mi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14236
@rxin Sure, Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14236: [SPARK-16588][SQL] Missed API fix for a function ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14236: [SPARK-16588][SQL] Missed API fix for a function name mi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14236
**[Test build #62427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62427/consoleFull)** for PR 14236 at commit [`d947be6`](https://github.com/apache/spark/commit/d947be6b039aa3c4744b0be2c06c1bbb4c3500fc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14236: [SPARK-16588][SQL] Missed API fix for a function name mi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14236
Since it is a small change I will just push a commit myself. Thanks for noticing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14236: [SPARK-16588][SQL] Missed API fix for a function name mi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14236
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62427/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14236: [SPARK-16588][SQL] Missed API fix for a function name mi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14236
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org