[GitHub] [druid] awelsh93 commented on a change in pull request #9938: Add https to druid-influxdb-emitter extension

[GitBox <gi...@apache.org>]

awelsh93 commented on a change in pull request #9938:
URL: https://github.com/apache/druid/pull/9938#discussion_r456344413



##########
File path: extensions-contrib/influxdb-emitter/src/main/java/org/apache/druid/emitter/influxdb/InfluxdbEmitterConfig.java
##########
@@ -130,6 +159,10 @@ public int hashCode()
   {
     int result = getHostname().hashCode();
     result = 31 * result + getPort();
+    result = 31 * result + getProtocol().hashCode();
+    result = 31 * result + (getTrustStorePath() != null ? getTrustStorePath().hashCode() : 0);
+    result = 31 * result + (getTrustStoreType() != null ? getTrustStoreType().hashCode() : 0);
+    result = 31 * result + (getTrustStorePassword() != null ? getTrustStorePassword().hashCode() : 0);

Review comment:
       How does `EqualsVerifier` work? The test I added is failing on 
   
   > Non-nullity: equals throws NullPointerException on field port.
   
   but if port is null then it gets set to a default value in the config's constructor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org