[jira] [Commented] (RANGER-961) Remove KMS xml-security-impl dependency

["rangerqa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303871#comment-15303871 ] 

rangerqa commented on RANGER-961:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12806601/0001-RANGER-961-Remove-KMS-xml-security-impl-dependency.patch
  against master revision a5200b4.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-RANGER-Build/218//testReport/
Console output: https://builds.apache.org/job/PreCommit-RANGER-Build/218//console

This message is automatically generated.

> Remove KMS xml-security-impl dependency
> ---------------------------------------
>
>                 Key: RANGER-961
>                 URL: https://issues.apache.org/jira/browse/RANGER-961
>             Project: Ranger
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 0.6.0
>
>         Attachments: 0001-RANGER-961-Remove-KMS-xml-security-impl-dependency.patch
>
>
> The KMS module uses the xml-security-impl dependency just to get a Base64 encoder/decoder. This is not necessary as one is already available in Commons Codec, and in fact is used in other classes in this module.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)