You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/04 23:34:22 UTC

[GitHub] [geode] gesterzhou commented on a change in pull request #6093: DRAFT: GEODE-9003: Remove the member from replicates as GII candidate if it'…

gesterzhou commented on a change in pull request #6093:
URL: https://github.com/apache/geode/pull/6093#discussion_r587909087



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/persistence/PersistenceAdvisorImpl.java
##########
@@ -533,7 +535,8 @@ public boolean checkMyStateOnMembers(Set<InternalDistributedMember> replicates)
         String message = String.format(
             "Region %s remote member %s with persistent data %s was not part of the same distributed system as the local data from %s",
             regionPath, member, remoteId, myId);
-        throw new ConflictingPersistentDataException(message);
+        logger.warn(message);
+        iterator.remove();

Review comment:
       it won't. This data structure is in reply message. Only the message processor will use it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org