You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/17 20:48:02 UTC
[GitHub] [arrow] kou opened a new pull request, #35653: GH-35651: [C++] Don't use self-move with MinGW
kou opened a new pull request, #35653:
URL: https://github.com/apache/arrow/pull/35653
### Rationale for this change
Because MinGW g++ reports a warning:
```text
D:/a/arrow/arrow/cpp/src/arrow/util/small_vector_test.cc:417:22:
warning: moving 'moved_moved_ints' of type
'arrow::internal::TestSmallStaticVector<
arrow::internal::VectorIntLikeParam<
arrow::internal::StaticVectorTraits, arrow::MoveOnlyDataType> >::IntVectorType<5>'
{aka 'arrow::internal::StaticVectorImpl<
arrow::MoveOnlyDataType, 5, arrow::internal::StaticVectorStorage<arrow::MoveOnlyDataType, 5, true> >'}
to itself [-Wself-move]
417 | moved_moved_ints = std::move(moved_moved_ints);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/a/arrow/arrow/cpp/src/arrow/util/small_vector_test.cc:417:22: note: remove 'std::move' call
```
### What changes are included in this PR?
Disable self-move code only for MinGW.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35653: GH-35651: [C++] Don't use self-move with MinGW
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35653:
URL: https://github.com/apache/arrow/pull/35653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35653: GH-35651: [C++] Don't use self-move with MinGW
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35653:
URL: https://github.com/apache/arrow/pull/35653#issuecomment-1555959880
Benchmark runs are scheduled for baseline = 350ad2723939dab93611c2bc407e4ec28a3f5bd2 and contender = 3e4eaa917fa9b09a923d255adee520aa68a4e78c. 3e4eaa917fa9b09a923d255adee520aa68a4e78c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b93c487045c74654b0de0482896dd21c...0fb5d12a13ab40438a3006581b42239a/)
[Finished :arrow_down:0.33% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/269dffffbb8f4862aa191f1dfa32ad6a...370b402801084fc2acdfd3caaf3f6579/)
[Finished :arrow_down:1.63% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1465dc35112e48eeabfc13e1855c2385...4dc8cca243854c2889f480decb95e0ee/)
[Finished :arrow_down:0.6% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0434bb470cc247348d68382ab06fa99a...86c5130da89f4eba92d05466de6c7b2a/)
Buildkite builds:
[Finished] [`3e4eaa91` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2894)
[Finished] [`3e4eaa91` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2930)
[Finished] [`3e4eaa91` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2895)
[Finished] [`3e4eaa91` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2920)
[Finished] [`350ad272` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2893)
[Finished] [`350ad272` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2929)
[Finished] [`350ad272` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2894)
[Finished] [`350ad272` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2919)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35653: GH-35651: [C++] Don't use self-move with MinGW
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35653:
URL: https://github.com/apache/arrow/pull/35653#issuecomment-1555960490
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1465dc35112e48eeabfc13e1855c2385...4dc8cca243854c2889f480decb95e0ee/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35653: GH-35651: [C++] Don't use self-move with MinGW
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35653:
URL: https://github.com/apache/arrow/pull/35653#issuecomment-1552065380
:warning: GitHub issue #35651 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35653: GH-35651: [C++] Don't use self-move with MinGW
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35653:
URL: https://github.com/apache/arrow/pull/35653#issuecomment-1552208676
The `self-move` warning was suppressed in build log: https://github.com/apache/arrow/actions/runs/5007768864/jobs/8974807896#step:7:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35653: GH-35651: [C++] Don't use self-move with MinGW
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35653:
URL: https://github.com/apache/arrow/pull/35653#issuecomment-1552065347
* Closes: #35651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org