You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2012/08/16 22:18:28 UTC
Re: Review Request: SHINDIG-1821 Add support for @following, @followers,
et. according to OS 2.5 spec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6140/#review10429
-----------------------------------------------------------
trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java
<https://reviews.apache.org/r/6140/#comment22226>
Could you?
trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java
<https://reviews.apache.org/r/6140/#comment22227>
I think we should bind the names associated with the types in the enum. Then we can iterate over the enums and return the types with the matching names rather than have that logic separated in another method.
trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/6140/#comment22228>
You could also bind the link key in the enum and abstract a ton of this code.
- Dan Dumont
On July 25, 2012, 6:02 p.m., Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6140/
> -----------------------------------------------------------
>
> (Updated July 25, 2012, 6:02 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1821 for details
>
>
> This addresses bug SHINDIG-1821.
> https://issues.apache.org/jira/browse/SHINDIG-1821
>
>
> Diffs
> -----
>
> trunk/content/sampledata/canonicaldb.json 1364039
> trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java 1364039
> trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1364039
>
> Diff: https://reviews.apache.org/r/6140/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Henry Saputra
>
>