You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Leonard Xu <xb...@gmail.com> on 2023/11/22 06:42:11 UTC
[NOTICE] flink-table-planner module has been migrated to JUnit5
Hi, all
There are a lot of JUnit4 tests in flink-table-planner module, but now Jiabao and I have just migrated all tests to JUnit5 through FLINK-29451[1].
Please use JUnit5 tests when submitting new PRs for flink-table-planner module. The opened PRs for flink-table-planner module need to rebase to the latest master.
Thanks Jiabao for the huge efforts.
Best,
Leonard
[1]https://issues.apache.org/jira/browse/FLINK-29541
Re: [NOTICE] flink-table-planner module has been migrated to JUnit5
Posted by Yuxin Tan <ta...@gmail.com>.
Thanks Jiabao for the quick response.
Best,
Yuxin
Jiabao Sun <ji...@xtransfer.cn.invalid> 于2023年11月23日周四 11:25写道：
> Thanks Yuxin for you reminder,
>
> I will complete it today.
>
> Best,
> Jiabao
>
>
> > 2023年11月22日 16:26，Yuxin Tan <ta...@gmail.com> 写道：
> >
> > Hi, Leonard, jiabao
> >
> > Thanks for migrating the test classes.
> >
> > I have noticed that many test classes (e.g.,
> FlinkCalciteCatalogReaderTest)
> > in flink-table (including flink-table-planner) have been updated to use
> > AssertJ.
> > However, their dependent test classes still utilize org.junit.Test or
> > org.junit.Before,
> > etc., whereas they should be using org.junit.jupiter.api.Test, etc. These
> > classes are mostly from the issue FLINK-26582[1]. Maybe we need to fix
> > these classes as well.
> >
> > [1] https://github.com/apache/flink/pull/19039
> >
> > Best,
> > Yuxin
> >
> >
> > Jane Chan <qi...@gmail.com> 于2023年11月22日周三 15:32写道：
> >
> >> Thanks Leonard and Jiabao for your tremendous efforts in this regard!
> >>
> >> Best,
> >> Jane
> >>
> >> On Wed, Nov 22, 2023 at 2:42 PM Leonard Xu <xb...@gmail.com> wrote:
> >>
> >>> Hi, all
> >>>
> >>> There are a lot of JUnit4 tests in flink-table-planner module, but now
> >>> Jiabao and I have just migrated all tests to JUnit5 through
> >> FLINK-29451[1].
> >>>
> >>> Please use JUnit5 tests when submitting new PRs for flink-table-planner
> >>> module. The opened PRs for flink-table-planner module need to rebase to
> >> the
> >>> latest master.
> >>>
> >>> Thanks Jiabao for the huge efforts.
> >>>
> >>>
> >>> Best,
> >>> Leonard
> >>>
> >>> [1]https://issues.apache.org/jira/browse/FLINK-29541
> >>
>
>
Re: [NOTICE] flink-table-planner module has been migrated to JUnit5
Posted by Jiabao Sun <ji...@xtransfer.cn.INVALID>.
Thanks Yuxin for you reminder,
I will complete it today.
Best,
Jiabao
> 2023年11月22日 16:26，Yuxin Tan <ta...@gmail.com> 写道：
>
> Hi, Leonard, jiabao
>
> Thanks for migrating the test classes.
>
> I have noticed that many test classes (e.g., FlinkCalciteCatalogReaderTest)
> in flink-table (including flink-table-planner) have been updated to use
> AssertJ.
> However, their dependent test classes still utilize org.junit.Test or
> org.junit.Before,
> etc., whereas they should be using org.junit.jupiter.api.Test, etc. These
> classes are mostly from the issue FLINK-26582[1]. Maybe we need to fix
> these classes as well.
>
> [1] https://github.com/apache/flink/pull/19039
>
> Best,
> Yuxin
>
>
> Jane Chan <qi...@gmail.com> 于2023年11月22日周三 15:32写道：
>
>> Thanks Leonard and Jiabao for your tremendous efforts in this regard!
>>
>> Best,
>> Jane
>>
>> On Wed, Nov 22, 2023 at 2:42 PM Leonard Xu <xb...@gmail.com> wrote:
>>
>>> Hi, all
>>>
>>> There are a lot of JUnit4 tests in flink-table-planner module, but now
>>> Jiabao and I have just migrated all tests to JUnit5 through
>> FLINK-29451[1].
>>>
>>> Please use JUnit5 tests when submitting new PRs for flink-table-planner
>>> module. The opened PRs for flink-table-planner module need to rebase to
>> the
>>> latest master.
>>>
>>> Thanks Jiabao for the huge efforts.
>>>
>>>
>>> Best,
>>> Leonard
>>>
>>> [1]https://issues.apache.org/jira/browse/FLINK-29541
>>
Re: [NOTICE] flink-table-planner module has been migrated to JUnit5
Posted by Yuxin Tan <ta...@gmail.com>.
Hi, Leonard, jiabao
Thanks for migrating the test classes.
I have noticed that many test classes (e.g., FlinkCalciteCatalogReaderTest)
in flink-table (including flink-table-planner) have been updated to use
AssertJ.
However, their dependent test classes still utilize org.junit.Test or
org.junit.Before,
etc., whereas they should be using org.junit.jupiter.api.Test, etc. These
classes are mostly from the issue FLINK-26582[1]. Maybe we need to fix
these classes as well.
[1] https://github.com/apache/flink/pull/19039
Best,
Yuxin
Jane Chan <qi...@gmail.com> 于2023年11月22日周三 15:32写道：
> Thanks Leonard and Jiabao for your tremendous efforts in this regard!
>
> Best,
> Jane
>
> On Wed, Nov 22, 2023 at 2:42 PM Leonard Xu <xb...@gmail.com> wrote:
>
> > Hi, all
> >
> > There are a lot of JUnit4 tests in flink-table-planner module, but now
> > Jiabao and I have just migrated all tests to JUnit5 through
> FLINK-29451[1].
> >
> > Please use JUnit5 tests when submitting new PRs for flink-table-planner
> > module. The opened PRs for flink-table-planner module need to rebase to
> the
> > latest master.
> >
> > Thanks Jiabao for the huge efforts.
> >
> >
> > Best,
> > Leonard
> >
> > [1]https://issues.apache.org/jira/browse/FLINK-29541
>
Re: [NOTICE] flink-table-planner module has been migrated to JUnit5
Posted by Jane Chan <qi...@gmail.com>.
Thanks Leonard and Jiabao for your tremendous efforts in this regard!
Best,
Jane
On Wed, Nov 22, 2023 at 2:42 PM Leonard Xu <xb...@gmail.com> wrote:
> Hi, all
>
> There are a lot of JUnit4 tests in flink-table-planner module, but now
> Jiabao and I have just migrated all tests to JUnit5 through FLINK-29451[1].
>
> Please use JUnit5 tests when submitting new PRs for flink-table-planner
> module. The opened PRs for flink-table-planner module need to rebase to the
> latest master.
>
> Thanks Jiabao for the huge efforts.
>
>
> Best,
> Leonard
>
> [1]https://issues.apache.org/jira/browse/FLINK-29541