You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Nishan Shetty (Created) (JIRA)" <ji...@apache.org> on 2012/02/17 12:04:01 UTC

[jira] [Created] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
-------------------------------------------------------------------------------------

                 Key: MAPREDUCE-3873
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: mrv2, nodemanager
    Affects Versions: 0.23.0
            Reporter: Nishan Shetty


Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
It is not getting decommisioned.But if the hostname is given, decommissioning is happening.

I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262623#comment-13262623 ] 

Hadoop QA commented on MAPREDUCE-3873:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12524425/MAPREDUCE-3873.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.yarn.server.TestContainerManagerSecurity
                  org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens
                  org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
                  org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
                  org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
                  org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs
                  org.apache.hadoop.mapred.TestClientRedirect
                  org.apache.hadoop.mapreduce.TestYarnClientProtocolProvider
                  org.apache.hadoop.mapreduce.security.TestJHSSecurity

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2314//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2314//console

This message is automatically generated.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Priority: Minor
>         Attachments: MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289888#comment-13289888 ] 

Hudson commented on MAPREDUCE-3873:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2344 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2344/])
    MAPREDUCE-3873. Fixed NodeManagers' decommissioning at RM to accept IP addresses also. Contributed by xieguiming and vinodkv. (Revision 1346671)

     Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346671
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java

                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Status: Open  (was: Patch Available)
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Attachment: MAPREDUCE-3873-20120502.txt
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Attachment: MAPREDUCE-3873-20120502.txt

Patch with tests. Tests fail without the fix and pass with.

Will push this in if/when Jenkins blesses..
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267059#comment-13267059 ] 

Hadoop QA commented on MAPREDUCE-3873:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525364/MAPREDUCE-3873-20120502.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2351//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2351//console

This message is automatically generated.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Status: Patch Available  (was: Open)
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289882#comment-13289882 ] 

Hudson commented on MAPREDUCE-3873:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #2325 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2325/])
    MAPREDUCE-3873. Fixed NodeManagers' decommissioning at RM to accept IP addresses also. Contributed by xieguiming and vinodkv. (Revision 1346671)

     Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346671
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java

                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

      Resolution: Fixed
    Release Note: Fixed NodeManagers' decommissioning at RM to accept IP addresses also.
          Status: Resolved  (was: Patch Available)

I just committed this to trunk and branch-2.0. Thanks Xeiguiming!
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Patch looks good. +1.

It is easy to write a test, I already have one. Let me upload the patch with a test case.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Nishan Shetty (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212404#comment-13212404 ] 

Nishan Shetty commented on MAPREDUCE-3873:
------------------------------------------

same is observed for "yarn.resourcemanager.nodes.include-path" configuration.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Priority: Minor
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "xieguiming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

xieguiming reassigned MAPREDUCE-3873:
-------------------------------------

    Assignee: xieguiming
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289876#comment-13289876 ] 

Hudson commented on MAPREDUCE-3873:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2398 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2398/])
    MAPREDUCE-3873. Fixed NodeManagers' decommissioning at RM to accept IP addresses also. Contributed by xieguiming and vinodkv. (Revision 1346671)

     Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346671
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java

                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269738#comment-13269738 ] 

Robert Joseph Evans commented on MAPREDUCE-3873:
------------------------------------------------

Vinod and Xiequiming,

The combined patch looks good.  +1

Vinod if you want me to commit this just let me know.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Priority: Minor  (was: Major)

I observed the same, but this is minor.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Priority: Minor
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Attachment: MAPREDUCE-3873-20120502.1.txt

A minor fix to avoid the IP lookup in all cases.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "xieguiming (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267126#comment-13267126 ] 

xieguiming commented on MAPREDUCE-3873:
---------------------------------------

Hi Vinod:
  Thanks for your testCase. TestResourceTrackerService is very good. At the beginning, I only focus on the NodesListManager:isValidNode function.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266966#comment-13266966 ] 

Hadoop QA commented on MAPREDUCE-3873:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525352/MAPREDUCE-3873-20120502.1.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2349//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2349//console

This message is automatically generated.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289797#comment-13289797 ] 

Hadoop QA commented on MAPREDUCE-3873:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12531004/MAPREDUCE-3873-20120502.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2439//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2439//console

This message is automatically generated.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Status: Patch Available  (was: Open)
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Attachment: MAPREDUCE-3873-20120502.txt

Alright, that's buggy logic, cannot optimize the ip look up away. Reverting to old patch that [~xieguiming] wrote up.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "xieguiming (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263322#comment-13263322 ] 

xieguiming commented on MAPREDUCE-3873:
---------------------------------------

The modified function:
  public boolean isValidNode(String hostName) {
    synchronized (hostsReader) {
      Set<String> hostsList = hostsReader.getHosts();
      Set<String> excludeList = hostsReader.getExcludedHosts();
      {color:red}     
      String ip = NetUtils.normalizeHostName(hostName);
       {color}
      return (hostsList.isEmpty() || hostsList.contains(hostName) || hostsList
          .contains(ip))
          && !(excludeList.contains(hostName) || excludeList.contains(ip));
    }
  }

and the function NetUtils.normalizeHostName(hostName) can not be mocked.
So, I think this patch do not need provide the unit testcase.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Priority: Minor
>         Attachments: MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Hadoop Flags: Reviewed
          Status: Patch Available  (was: Open)
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Status: Open  (was: Patch Available)
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290166#comment-13290166 ] 

Hudson commented on MAPREDUCE-3873:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #1102 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1102/])
    MAPREDUCE-3873. Fixed NodeManagers' decommissioning at RM to accept IP addresses also. Contributed by xieguiming and vinodkv. (Revision 1346671)

     Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346671
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java

                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Status: Patch Available  (was: Open)
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266915#comment-13266915 ] 

Hadoop QA commented on MAPREDUCE-3873:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525347/MAPREDUCE-3873-20120502.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2348//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2348//console

This message is automatically generated.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "xieguiming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

xieguiming updated MAPREDUCE-3873:
----------------------------------

    Status: Patch Available  (was: Open)

The patch will support that we config either hostname or ip in the "yarn.resourcemanager.nodes.exclude-path" and yarn.resourcemanager.nodes.include-path file.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Priority: Minor
>         Attachments: MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Fix Version/s: 2.0.1-alpha
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "xieguiming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

xieguiming updated MAPREDUCE-3873:
----------------------------------

    Attachment: MAPREDUCE-3873.patch
    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Priority: Minor
>         Attachments: MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290085#comment-13290085 ] 

Hudson commented on MAPREDUCE-3873:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #1069 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1069/])
    MAPREDUCE-3873. Fixed NodeManagers' decommissioning at RM to accept IP addresses also. Contributed by xieguiming and vinodkv. (Revision 1346671)

     Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346671
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java

                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed MAPREDUCE-3873.
------------------------------------

    
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>             Fix For: 2.0.2-alpha
>
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Bhallamudi Venkata Siva Kamesh (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211836#comment-13211836 ] 

Bhallamudi Venkata Siva Kamesh commented on MAPREDUCE-3873:
-----------------------------------------------------------

*HostsFileReader#readFileToSet* reading entries from the file and adding those entries to set. This entry can be either an *IP Address* or a *hostname*. However while validating a hostname,checking whether the hostname is part of set of entries excluded. So just comparing *hostname* with *IP address*, which returns false. 

I think, while adding entries to set in *HostsFileReader#readFileToSet*, we should add the hostname of the entry, rather than just adding it.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3873) Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3873:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Back into business. This patch was in flight for a while, will push this in once Jenkins blesses for one last time.
                
> Nodemanager is not getting decommisioned if the absolute ip is given in exclude file.
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3873
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Nishan Shetty
>            Assignee: xieguiming
>            Priority: Minor
>         Attachments: MAPREDUCE-3873-20120502.1.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873-20120502.txt, MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in every machine the other machines ip-host mapping is specified).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira