You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "xu1009 (via GitHub)" <gi...@apache.org> on 2023/03/24 08:01:40 UTC
[GitHub] [skywalking] xu1009 opened a new issue, #10589: [Feature] support collect sql parameters when useServerPrepStmts in mysql
xu1009 opened a new issue, #10589:
URL: https://github.com/apache/skywalking/issues/10589
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
when trace_sql_parameters is true in skywalking config and set useServerPrepStmts true in mysql，preparedstatment sql parameters can not be collected
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #10589: [Feature] support collect sql parameters when useServerPrepStmts in mysql
Posted by "xu1009 (via GitHub)" <gi...@apache.org>.
xu1009 commented on issue #10589:
URL: https://github.com/apache/skywalking/issues/10589#issuecomment-1482615448
useServerPrepStmt true, jdbc will use ServerPreparedStatement instad of PreparedStatement build sql and execute, the ServerPreparedStatement overwrite some method, the mysql plugin only enahnce PreparedStatement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10589: [Feature] support collect sql parameters when useServerPrepStmts in mysql
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10589:
URL: https://github.com/apache/skywalking/issues/10589#issuecomment-1482429672
How is this param working? I am new about this. Is this different use case from JDBC perspective?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10589: [Feature] support collect sql parameters when useServerPrepStmts in mysql
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10589:
URL: https://github.com/apache/skywalking/issues/10589#issuecomment-1482414694
I am not following. I remember we have this config already.
What do I miss?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on issue #10589: [Feature] support collect sql parameters when useServerPrepStmts in mysql
Posted by "xu1009 (via GitHub)" <gi...@apache.org>.
xu1009 commented on issue #10589:
URL: https://github.com/apache/skywalking/issues/10589#issuecomment-1482425890
when enable useServerPrepStmt like jdbc:mysql://localhost/test?useServerPrepStm=true, even if trace_sql_parameters is true, agent can not collect the sql parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10589: [Feature] support collect sql parameters when useServerPrepStmts in mysql
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10589: [Feature] support collect sql parameters when useServerPrepStmts in mysql
URL: https://github.com/apache/skywalking/issues/10589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10589: [Feature] support collect sql parameters when useServerPrepStmts in mysql
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10589:
URL: https://github.com/apache/skywalking/issues/10589#issuecomment-1487835844
Fixed by https://github.com/apache/skywalking-java/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org