[GitHub] [incubator-kvrocks] xxaier commented on a diff in pull request #1474: docker can use env conf

["xxaier (via GitHub)" <gi...@apache.org>]

xxaier commented on code in PR #1474:
URL: https://github.com/apache/incubator-kvrocks/pull/1474#discussion_r1205664665


##########
Dockerfile:
##########
@@ -57,10 +57,9 @@ VOLUME /var/lib/kvrocks
 
 RUN chown kvrocks:kvrocks /var/lib/kvrocks
 
-COPY ./LICENSE ./NOTICE ./DISCLAIMER ./
+COPY ./docker/run.sh ./LICENSE ./NOTICE ./DISCLAIMER ./
 COPY ./licenses ./licenses
 COPY ./kvrocks.conf /var/lib/kvrocks/
-
 EXPOSE 6666:6666
 
-ENTRYPOINT ["./bin/kvrocks", "-c", "/var/lib/kvrocks/kvrocks.conf", "--dir", "/var/lib/kvrocks", "--pidfile", "/var/run/kvrocks/kvrocks.pid"]
+ENTRYPOINT ["./run.sh"]

Review Comment:
   see https://stackoverflow.com/questions/37904682/how-do-i-use-docker-environment-variable-in-entrypoint-array
   hard to do this



##########
Dockerfile:
##########
@@ -57,10 +57,9 @@ VOLUME /var/lib/kvrocks
 
 RUN chown kvrocks:kvrocks /var/lib/kvrocks
 
-COPY ./LICENSE ./NOTICE ./DISCLAIMER ./
+COPY ./docker/run.sh ./LICENSE ./NOTICE ./DISCLAIMER ./
 COPY ./licenses ./licenses
 COPY ./kvrocks.conf /var/lib/kvrocks/
-
 EXPOSE 6666:6666
 
-ENTRYPOINT ["./bin/kvrocks", "-c", "/var/lib/kvrocks/kvrocks.conf", "--dir", "/var/lib/kvrocks", "--pidfile", "/var/run/kvrocks/kvrocks.pid"]
+ENTRYPOINT ["./run.sh"]

Review Comment:
   see https://stackoverflow.com/questions/37904682/how-do-i-use-docker-environment-variable-in-entrypoint-array
   hard to do this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org