[GitHub] [spark] LuciferYang commented on pull request #34313: [SPARK-37013][SQL] Ensure `format_string` has same behavior when using Java 8 and Java 17

[GitBox <gi...@apache.org>]

LuciferYang commented on pull request #34313:
URL: https://github.com/apache/spark/pull/34313#issuecomment-945484637


   I think there are three ways to fix this issue
   
   1. Make Java 17 compatible with Java 8, just as this pr does
   
   2. Using the behavior of Java 17,  add judgment `FormatString` function to  prohibit the use of `%0$` pattern like 
   ```
   if (pattern.contains("%0$")) {
       throw new IllegalArgumentException
   }
   ```
   and it looks more like what is expected in the  test comment: `PostgreSQL throw ERROR:  format specifies argument 0, but arguments are numbered from 1`
   
   3. Maintain different behaviors and change the test case, just as https://github.com/apache/spark/pull/34153/files# does
   
   cc @srowen @wangyum @dongjoon-hyun @MaxGekk 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org