You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2025/12/12 00:28:18 UTC
[PR] GH-48463: [Python] Improve error message in CheckTypeExact arrow_to_pandas.cc [arrow]
HyukjinKwon opened a new pull request, #48464:
URL: https://github.com/apache/arrow/pull/48464
### Rationale for this change
https://github.com/apache/arrow/commit/3b000b7062b5614a02134d1a90ae381b937aac07 first introduced this todo as below
https://github.com/apache/arrow/blob/0bfbd19bce3e10163537b349f9205b635c87eea7/python/pyarrow/src/arrow/python/arrow_to_pandas.cc#L1130
Then, the error messages are actually handled at the higher level if I am not mistaken (e.g., 05bc63c3b76a5fc865434f596c63ff0f26388f69 introduced `_sanitize_arrays` and casting at `asarray` ). So the end users would not reach this. This is more for a sanity check and developers to debug.
This is to improve the error message for the sanity check and developers.
### What changes are included in this PR?
This PR improves the error message in CheckTypeExact arrow_to_pandas.cc by adding the corresponding NumPy string type.
### Are these changes tested?
Unittest is added, and manually run as below:
```
pytest pyarrow/tests/test_cpp_internals.py::test_get_numpy_type_name -v
```
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48463: [Python] Improve error message in CheckTypeExact arrow_to_pandas.cc [arrow]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48464:
URL: https://github.com/apache/arrow/pull/48464#issuecomment-3673959036
@rok @icexelloss @AlenkaF could this be merged by any chance? 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48463: [Python] Improve error message in CheckTypeExact arrow_to_pandas.cc [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48464:
URL: https://github.com/apache/arrow/pull/48464#issuecomment-3691728737
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6a481e5f656333169d23d3a1d6fdc45f45d03bdb.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/58931132293) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48463: [Python] Improve error message in CheckTypeExact arrow_to_pandas.cc [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok merged PR #48464:
URL: https://github.com/apache/arrow/pull/48464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48463: [Python] Improve error message in CheckTypeExact arrow_to_pandas.cc [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48464:
URL: https://github.com/apache/arrow/pull/48464#issuecomment-3644378185
:warning: GitHub issue #48463 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org