You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/18 15:52:29 UTC
[GitHub] [incubator-tvm] t-vi opened a new pull request #5843: ffi (Object): make class dict visible in instances
t-vi opened a new pull request #5843:
URL: https://github.com/apache/incubator-tvm/pull/5843
In Python, generic objects (i.e. non-types/classes) inherit the `__dir__` elements from their class.
This enable tab completion in interactive environments like Jupyter notebooks.
Reference for this behaviour is Python's `__dir__` for objects:
https://github.com/python/cpython/blob/8f192d12af82c4dc40730bf59814f6a68f68f950/Objects/typeobject.c#L4854-L4899
I'll readily admit that I don't know whether the location for the test I offer is a good one. It seemed to be a place where low-level stuff is tested and where this can blend in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5843: ffi (Object): make class dict visible in instances
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5843:
URL: https://github.com/apache/incubator-tvm/pull/5843#issuecomment-646226767
Thanks @t-vi !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #5843: ffi (Object): make class dict visible in instances
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5843:
URL: https://github.com/apache/incubator-tvm/pull/5843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] t-vi commented on pull request #5843: ffi (Object): make class dict visible in instances
Posted by GitBox <gi...@apache.org>.
t-vi commented on pull request #5843:
URL: https://github.com/apache/incubator-tvm/pull/5843#issuecomment-646121900
@tqchen / @zhiics I think you're closest to this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org