You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/08/04 16:48:46 UTC

[GitHub] mistercrunch commented on issue #3231: Add typescript support to start documenting the code

mistercrunch commented on issue #3231: Add typescript support to start documenting the code
URL: https://github.com/apache/incubator-superset/issues/3231#issuecomment-320297764
 
 
   Personally I'm not clear on the implications. Also unclear that TS is a solution to address documentation. There's nothing keeping us from documenting the React code we have now. To me the best way to document React is something like:
   https://github.com/storybooks/storybook
   
   Definitely want to be careful in jumping on the latest JS bandwagon (glad we passed on CoffeeScript for instance). Coming from Python I'm not super enthusiastic about types.
   
   Also not enthusiastic about adding a layer in the webpack delivery chain. I spent hours in dependency/webpack hell recently and clearly want to keep things lean in that area.
   
   So at least for now I think the odds are against TS unless someone can make a strong case for it and for the Apache committers to rally behind that decision.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services