You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "jiridanek (via GitHub)" <gi...@apache.org> on 2023/04/09 23:01:03 UTC
[GitHub] [qpid-python] jiridanek opened a new pull request, #6: pylint
jiridanek opened a new pull request, #6:
URL: https://github.com/apache/qpid-python/pull/6
https://github.com/jiridanek/qpid-python/actions/runs/4652820540/jobs/8233256030#step:9:21
These look like real bugs, but, the code worked ok with them, so I am not sure there is a point in messing with it. Anyways, this PR does just that, where it seems easy.
```
./qpid/datatypes.py:295:15: F821 undefined name 'TypeErrror'
raise TypeErrror("need one of hex or bytes")
^
./qpid/debug.py:43:41: F821 undefined name 'out'
traceback.print_stack(None, None, out)
^
./qpid/debug.py:46:39: F821 undefined name 'out'
traceback.print_stack(None, None, out)
^
./qpid/saslmech/scram.py:48:15: F821 undefined name 'SaslException'
raise SaslException("Server nonce does not start with client nonce")
^
./qpid/saslmech/scram.py:90:13: F821 undefined name 'SaslException'
raise SaslException("Server verification failed")
^
./qpid_tests/broker_0_10/management.py:699:16: F821 undefined name 'Empty'
except Empty:
^
./qpid_tests/broker_0_10/management.py:722:16: F821 undefined name 'Empty'
except Empty:
^
```
No idea what to do with this. That `xmlutil` is nowhere to be found. Except maybe https://pypi.org/project/xmlutil/. It is not imported, though. Anyways, it does not matter for qpid-cpp, so maybe let's ignore it.
```
./qpid/spec08.py:478:14: F821 undefined name 'xmlutil'
find_rules(xmlutil.parse(specfile), rules)
^
```
These look intentional. First, cause NameError in a test, and the four afterwards will blow up if anyone calls the method without overriding the abstract implementation, I guess.
```
./qpid/tests/__init__.py:62:5: F821 undefined name 'fdsa'
fdsa
^
./qpid/connection08.py:338:26: F821 undefined name 'abstract'
def encode(self, enc): abstract
^
./qpid/connection08.py:340:32: F821 undefined name 'abstract'
def decode(spec, dec, size): abstract
^
./qpid/packer.py:24:22: F821 undefined name 'abstract'
def read(self, n): abstract
^
./qpid/packer.py:26:23: F821 undefined name 'abstract'
def write(self, s): abstract
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-python] jiridanek merged pull request #6: QPID-7070: add flake8 to CI as first step towards PEP-8, fix some most egregious things reported
Posted by "jiridanek (via GitHub)" <gi...@apache.org>.
jiridanek merged PR #6:
URL: https://github.com/apache/qpid-python/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-python] jiridanek commented on pull request #6: pylint
Posted by "jiridanek (via GitHub)" <gi...@apache.org>.
jiridanek commented on PR #6:
URL: https://github.com/apache/qpid-python/pull/6#issuecomment-1501234518
see https://issues.apache.org/jira/browse/QPID-7070, issue for adding flake8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-python] jiridanek commented on pull request #6: pylint
Posted by "jiridanek (via GitHub)" <gi...@apache.org>.
jiridanek commented on PR #6:
URL: https://github.com/apache/qpid-python/pull/6#issuecomment-1501235361
heres issue for the abstract methods https://issues.apache.org/jira/browse/QPID-4015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org